Skip to content

azurerm_search_service: keep network_rule_bypass_option when only update allowed_ips#29246

Merged
katbyte merged 1 commit intohashicorp:mainfrom
wuxu92:search/update-allowed-ips-29234
May 27, 2025
Merged

azurerm_search_service: keep network_rule_bypass_option when only update allowed_ips#29246
katbyte merged 1 commit intohashicorp:mainfrom
wuxu92:search/update-allowed-ips-29234

Conversation

@wuxu92
Copy link
Collaborator

@wuxu92 wuxu92 commented Apr 2, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The network_rule_bypass_option was set to nil when only update allowed_ips property, this cause the network_rule_bypass_option gets cleared. This PR is to fix this issue.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
--- PASS: TestAccSearchService_ipRules (369.87s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/search369.903s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #29234

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌦️

@katbyte katbyte merged commit 819df71 into hashicorp:main May 27, 2025
31 checks passed
@github-actions github-actions bot added this to the v4.31.0 milestone May 27, 2025
katbyte added a commit that referenced this pull request May 27, 2025
sreallymatt pushed a commit that referenced this pull request May 29, 2025
sreallymatt added a commit that referenced this pull request May 29, 2025
* Update CHANGELOG.md for #29433

* Update CHANGELOG.md for #29319

* Update CHANGELOG.md for #29373

* Update CHANGELOG.md #29024

* Update CHANGELOG.md #29666

* Update CHANGELOG.md #29649

* Update CHANGELOG.md #29715

* Update CHANGELOG.md #29273

* Update CHANGELOG.md #29709

* Update CHANGELOG.md #29624

* Update CHANGELOG.md #29710

* Update CHANGELOG.md

* Update CHANGELOG.md #28262

* Update CHANGELOG.md #29499

* Update CHANGELOG.md #29377

* Update CHANGELOG.md #29337

* Update CHANGELOG.md #29246

* Update CHANGELOG.md #29221

* Update CHANGELOG.md #29216

* Update CHANGELOG.md #28133

* Update CHANGELOG.md #29669

* Update CHANGELOG.md for #29717

* Update CHANGELOG.md #29310

* Update CHANGELOG.md #29466

* Update CHANGELOG.md #29723

* Update CHANGELOG.md #29716

* Update CHANGELOG.md

* Update CHANGELOG.md #29406

* correct resource name

* Update CHANGELOG.md #29482

* prep for release

---------

Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com>
Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
Co-authored-by: kt <kt@katbyte.me>
Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
Co-authored-by: Wyatt Fry <wyattfry@gmail.com>
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When the allowed_ips list is updated on an azurerm_search_service resource, the network_rule_bypass_option property gets cleared

2 participants