Skip to content

azurerm_web_pubsub_custom_certificate - fix crash when custom_certificate_id is in another Subscription#29410

Merged
catriona-m merged 1 commit intohashicorp:mainfrom
sinbai:signalr/fix_29401
Apr 25, 2025
Merged

azurerm_web_pubsub_custom_certificate - fix crash when custom_certificate_id is in another Subscription#29410
catriona-m merged 1 commit intohashicorp:mainfrom
sinbai:signalr/fix_29401

Conversation

@sinbai
Copy link
Contributor

@sinbai sinbai commented Apr 24, 2025

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fix #29401.

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sinbai I just left one query inline but once that is addressed I can take another look. Thanks!

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@catriona-m catriona-m merged commit 5024251 into hashicorp:main Apr 25, 2025
34 checks passed
@github-actions github-actions bot added this to the v4.28.0 milestone Apr 25, 2025
catriona-m added a commit that referenced this pull request Apr 25, 2025
teowa pushed a commit to teowa/terraform-provider-azurerm that referenced this pull request May 8, 2025
jackofallops added a commit that referenced this pull request May 9, 2025
* changelog for 4.28 release

* Update CHANGELOG.md #29410

* Update CHANGELOG.md #29397

* Update CHANGELOG.md #27454

* Update CHANGELOG.md #28919

* Update CHANGELOG.md #29443

* Update CHANGELOG.md #29443

* Update CHANGELOG.md #29456

* Update CHANGELOG.md for #29424

* Update CHANGELOG.md for #29150

* Update CHANGELOG.md #29435

* Update CHANGELOG.md #29431

* Update CHANGELOG.md #29396

* Update CHANGELOG.md #29197

* Update CHANGELOG.md for #28705

* Update CHANGELOG.md #28954

* Update CHANGELOG.md for #29363

* prep for release

---------

Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com>
Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: jackofallops <ste@hashicorp.com>
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic runtime error (NPE) when deploying WebPubsub with Custom Certificate in another Subscription

2 participants