storagecache: upgrade API version to 2024-07-01

[jiaweitao001]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[sreallymatt]

Hi @jiaweitao001, I've left 2 minor comments inline

[sreallymatt]

can we update this alias to be consistent with the version used?

Suggested change

	storagecache_2023_05_01 "github.com/hashicorp/go-azure-sdk/resource-manager/storagecache/2024-07-01"
	storagecache_2024_07_01 "github.com/hashicorp/go-azure-sdk/resource-manager/storagecache/2024-07-01"

[jiaweitao001]

Sure, will fix.

[sreallymatt]

Suggested change

	storagecache_2023_05_01 "github.com/hashicorp/go-azure-sdk/resource-manager/storagecache/2024-07-01"
	storagecache_2024_07_01 "github.com/hashicorp/go-azure-sdk/resource-manager/storagecache/2024-07-01"

[jiaweitao001]

Will fix.

[sreallymatt]

Hi @jiaweitao001, I ran the tests for this, and it looks like we can no longer create any new HPC Cache resources.

Error message: OperationNotAllowed: Unable to create HPC Cache due to product retirement. Please open a support ticket if you reached this in error.

Since we can't test that the HPC Cache resources still function as expected with this upgrade, would it be possible to only update azurerm_managed_lustre_file_system to use the newer API version, and leave the HPC Cache resources as is for now? (until we remove them, since based on the retirement notice this service will be fully removed in September, notice)

[jiaweitao001]

Hi @jiaweitao001, I ran the tests for this, and it looks like we can no longer create any new HPC Cache resources.

Error message: OperationNotAllowed: Unable to create HPC Cache due to product retirement. Please open a support ticket if you reached this in error.

Since we can't test that the HPC Cache resources still function as expected with this upgrade, would it be possible to only update azurerm_managed_lustre_file_system to use the newer API version, and leave the HPC Cache resources as is for now? (until we remove them, since based on the retirement notice this service will be fully removed in September, notice)

Hi @sreallymatt , the failing tests are irrelevant to the API version, they are failing of the same reason no matter the version is 2024-07-01 or 2023-05-01.

If we want to keep both the old version and the new, we will need old version client and new version one exist at the same time and both of them will fail the tests. I'm not sure if it's the right approach. WDYT?

[sreallymatt]

@jiaweitao001 agreed that the tests will fail regardless of the version, but since we can't test updating existing HPC cache resources, I think having 2 clients might be the safer option to ensure we're not breaking anything. (e.g. if a user already has HPC cache resources deployed, and they want to make an update, which based on the retirement notice should still be supported)

[sreallymatt]

Thanks for making those changes @jiaweitao001, LGTM!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.