`azurerm_netapp_pool` - add support for `cool_access_enabled` by mbfrahry · Pull Request #29468 · hashicorp/terraform-provider-azurerm

mbfrahry · 2025-05-02T23:18:52Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_netapp_pool - add support for cool_access_enabled [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

sreallymatt

Thanks @mbfrahry, I left some minor comments inline

sreallymatt · 2025-05-05T22:28:00Z

internal/services/netapp/netapp_pool_data_source.go

@@ -84,9 +89,12 @@ func dataSourceNetAppPoolRead(d *pluginsdk.ResourceData, meta interface{}) error

 	if model := resp.Model; model != nil {
 		d.Set("location", location.NormalizeNilable(&model.Location))


While it didn't change in this PR, should we change this to location.Normalize rather than passing the address of location?

Suggested change

d.Set("location", location.NormalizeNilable(&model.Location))

d.Set("location", location.Normalize(model.Location))

Good shout!

sreallymatt · 2025-05-05T22:28:07Z

website/docs/d/netapp_pool.html.markdown


 * `encryption_type` - The encryption type of the pool.

+* `cool_access_enabled` - Can the pool hold cool access enabled volumes?


Should we structure these as statements rather than questions?

Suggested change

* `cool_access_enabled` - Can the pool hold cool access enabled volumes?

* `cool_access_enabled` - Whether the NetApp Pool can hold cool access enabled volumes.

sreallymatt · 2025-05-05T22:28:58Z

website/docs/r/netapp_pool.html.markdown


 * `encryption_type` - (Optional) The encryption type of the pool. Valid values include `Single`, and `Double`. Defaults to `Single`. Changing this forces a new resource to be created.

+* `cool_access_enabled` - (Optional) Can the pool hold cool access enabled volumes? Defaults to `false`. 


Suggested change

* `cool_access_enabled` - (Optional) Can the pool hold cool access enabled volumes? Defaults to `false`.

* `cool_access_enabled` - (Optional) Whether the NetApp Pool can hold cool access enabled volumes. Defaults to `false`.

sreallymatt

Thanks @mbfrahry, LGTM!

* CHANGELOG.md for v4.29.0 * Update CHANGELOG.md #29042 * Update CHANGELOG.md #29492 * Update CHANGELOG.md #28953 * Update CHANGELOG.md for #29468 * Update CHANGELOG.md #29519 * Update CHANGELOG.md #29536 * Update CHANGELOG.md #29524 * Update CHANGELOG.md * Update CHANGELOG.md for #28193 * Update CHANGELOG.md #29239 * Update CHANGELOG.md #29614 * Update CHANGELOG.md #29601 * prep for release * Update CHANGELOG.md --------- Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com> Co-authored-by: jackofallops <ste@hashicorp.com>

* CHANGELOG.md for v4.29.0 * Update CHANGELOG.md hashicorp#29042 * Update CHANGELOG.md hashicorp#29492 * Update CHANGELOG.md hashicorp#28953 * Update CHANGELOG.md for hashicorp#29468 * Update CHANGELOG.md hashicorp#29519 * Update CHANGELOG.md hashicorp#29536 * Update CHANGELOG.md hashicorp#29524 * Update CHANGELOG.md * Update CHANGELOG.md for hashicorp#28193 * Update CHANGELOG.md hashicorp#29239 * Update CHANGELOG.md hashicorp#29614 * Update CHANGELOG.md hashicorp#29601 * prep for release * Update CHANGELOG.md --------- Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com> Co-authored-by: jackofallops <ste@hashicorp.com>

github-actions · 2025-06-09T02:28:46Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

azurerm_netapp_pool - add support for cool_access_enabled

a2863e7

mbfrahry requested a review from a team as a code owner May 2, 2025 23:18

github-actions bot added enhancement documentation service/netapp size/M labels May 2, 2025

sreallymatt reviewed May 5, 2025

View reviewed changes

github-actions bot added the waiting-response label May 5, 2025

sreallymatt self-assigned this May 5, 2025

Address review

9e1f7d9

github-actions bot removed the waiting-response label May 6, 2025

sreallymatt approved these changes May 8, 2025

View reviewed changes

mbfrahry merged commit bbdf61f into main May 9, 2025
33 checks passed

mbfrahry deleted the f-netapp-cool-access branch May 9, 2025 22:59

mbfrahry added this to the v4.29.0 milestone May 9, 2025

mbfrahry added a commit that referenced this pull request May 9, 2025

Update CHANGELOG.md for #29468

aca05bc

mbfrahry mentioned this pull request May 9, 2025

azurerm_netapp_pool | azurerm_netapp_volume - Support for Cool Access #28455

Closed

1 task

This was referenced May 19, 2025

InfraPatch Module and Provider Update CMInformatik/cmi-infrapatch#46

Closed

InfraPatch Module and Provider Update CMInformatik/cmi-infrapatch#48

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_netapp_pool` - add support for `cool_access_enabled`#29468

`azurerm_netapp_pool` - add support for `cool_access_enabled`#29468
mbfrahry merged 2 commits intomainfrom
f-netapp-cool-access

mbfrahry commented May 2, 2025

Uh oh!

sreallymatt left a comment

Uh oh!

sreallymatt May 5, 2025

Uh oh!

mbfrahry May 6, 2025

Uh oh!

sreallymatt May 5, 2025 •

edited

Loading

Uh oh!

sreallymatt May 5, 2025 •

edited

Loading

Uh oh!

sreallymatt left a comment

Uh oh!

Uh oh!

github-actions bot commented Jun 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -84,9 +89,12 @@ func dataSourceNetAppPoolRead(d *pluginsdk.ResourceData, meta interface{}) error

		if model := resp.Model; model != nil {
		d.Set("location", location.NormalizeNilable(&model.Location))

	d.Set("location", location.NormalizeNilable(&model.Location))
	d.Set("location", location.Normalize(model.Location))


		* `encryption_type` - The encryption type of the pool.

		* `cool_access_enabled` - Can the pool hold cool access enabled volumes?

	* `cool_access_enabled` - Can the pool hold cool access enabled volumes?
	* `cool_access_enabled` - Whether the NetApp Pool can hold cool access enabled volumes.


		* `encryption_type` - (Optional) The encryption type of the pool. Valid values include `Single`, and `Double`. Defaults to `Single`. Changing this forces a new resource to be created.

		* `cool_access_enabled` - (Optional) Can the pool hold cool access enabled volumes? Defaults to `false`.

	* `cool_access_enabled` - (Optional) Can the pool hold cool access enabled volumes? Defaults to `false`.
	* `cool_access_enabled` - (Optional) Whether the NetApp Pool can hold cool access enabled volumes. Defaults to `false`.

Conversation

mbfrahry commented May 2, 2025

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

Uh oh!

sreallymatt left a comment

Choose a reason for hiding this comment

Uh oh!

sreallymatt May 5, 2025

Choose a reason for hiding this comment

Uh oh!

mbfrahry May 6, 2025

Choose a reason for hiding this comment

Uh oh!

sreallymatt May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sreallymatt May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sreallymatt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jun 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sreallymatt May 5, 2025 •

edited

Loading

sreallymatt May 5, 2025 •

edited

Loading