Skip to content

azurerm_netapp_volume - support for large volume through large_volume_enabled configuration#29712

Merged
sreallymatt merged 9 commits intohashicorp:mainfrom
paulomarquesc:pmarques/large-volumes
Jun 2, 2025
Merged

azurerm_netapp_volume - support for large volume through large_volume_enabled configuration#29712
sreallymatt merged 9 commits intohashicorp:mainfrom
paulomarquesc:pmarques/large-volumes

Conversation

@paulomarquesc
Copy link
Contributor

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

ANF Large Volume feature implementation.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolume_largeVolume -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolume_largeVolume
=== PAUSE TestAccNetAppVolume_largeVolume
=== CONT  TestAccNetAppVolume_largeVolume
--- PASS: TestAccNetAppVolume_largeVolume (1028.62s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp        1028.641s

Related Issue(s)

Fixes #20639

Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @paulomarquesc, I've left a few comments inline

Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
@paulomarquesc paulomarquesc requested a review from sreallymatt May 28, 2025 00:31
@paulomarquesc paulomarquesc changed the title azurerm_netapp_volume - support for large volume through is_large_volume configuration azurerm_netapp_volume - support for large volume through large_volume_enabled configuration May 28, 2025
@paulomarquesc
Copy link
Contributor Author

@sreallymatt , any chance we can get this in today?

paulomarquesc and others added 2 commits June 2, 2025 10:31
Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
@paulomarquesc paulomarquesc requested a review from sreallymatt June 2, 2025 20:32
Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paulomarquesc, LGTM ✅

@sreallymatt sreallymatt merged commit 2edb004 into hashicorp:main Jun 2, 2025
34 checks passed
@github-actions github-actions bot added this to the v4.32.0 milestone Jun 2, 2025
sreallymatt added a commit that referenced this pull request Jun 2, 2025
@paulomarquesc
Copy link
Contributor Author

Thanks @sreallymatt !

wyattfry pushed a commit that referenced this pull request Jun 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for "Azure NetApp Files - Large volumes"

2 participants