azurerm_video_indexer_account - support for the public_network_access property

[sinbai]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Support for the public_network_access_enabled property.

Swagger:https://github.com/Azure/azure-rest-api-specs/blob/c9c3e8b9ec547d82c487f36f1126228f9eef0e79/specification/vi/resource-manager/Microsoft.VideoIndexer/stable/2025-04-01/vi.json#L1049C10-L1049C29

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [azurerm_video_indexer_account - public_network_access attribute is not available #29618]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #29618

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[sreallymatt]

Hi @sinbai, could you rename public_network_access_enabled to public_network_access and make it of type String? I've left some more context inline, once that's done I'll give this a more thorough review, thanks!

[sreallymatt]

While we've previously exposed the public network access enum as public_network_access_enabled (boolean), we're seeing more of these in the SDK with states other than Enabled and Disabled. Because of this, we'd prefer to standardize and expose these as public_network_access (string) moving forward to avoid potentially having to introduce a breaking change in the future.

[sinbai]

Hi @sreallymatt thanks for your time. I have fixed the comment, would you mind take another look?

[sreallymatt]

Thanks for making those changes @sinbai, this looks good, I've just left one question inline.

[sreallymatt]

Was there a specific reason for validating this insensitively? We'd prefer to use case-sensitive forms where possible

Suggested change

	ValidateFunc: validation.StringInSlice(accounts.PossibleValuesForPublicNetworkAccess(), true),
	ValidateFunc: validation.StringInSlice(accounts.PossibleValuesForPublicNetworkAccess(), false),

[sinbai]

Fixed.

[sinbai]

Thanks for making those changes @sinbai, this looks good, I've just left one question inline.

Hi @sreallymatt thanks for pointing that out - It's been fixed. Would you mind take another look?

[sreallymatt]

Thanks @sinbai, LGTM ✅

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.