Skip to content

azurerm_postgresql_flexible_server - Support versionless CMK key vault key id#29741

Merged
sreallymatt merged 2 commits intohashicorp:mainfrom
magodo:postgresql_flexible_server_cmk_versionless_id
May 29, 2025
Merged

azurerm_postgresql_flexible_server - Support versionless CMK key vault key id#29741
sreallymatt merged 2 commits intohashicorp:mainfrom
magodo:postgresql_flexible_server_cmk_versionless_id

Conversation

@magodo
Copy link
Collaborator

@magodo magodo commented May 29, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The azurerm_postgresql_flexible_server CMK key vault key id didn't support versionless id (see: #28981), but now it supports: https://techcommunity.microsoft.com/blog/adforpostgresql/new-versionless-cmk-in-azure-database-for-postgresql/4406743.

This PR adds that support back to azurerm_postgresql_flexible_server.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
💤  TF_ACC=1 go test -v -timeout=20h -parallel=20 -run='TestAccPostgresqlFlexibleServer_createWithCustomerManagedKey' ./internal/services/postgres
=== RUN   TestAccPostgresqlFlexibleServer_createWithCustomerManagedKey
=== PAUSE TestAccPostgresqlFlexibleServer_createWithCustomerManagedKey
=== RUN   TestAccPostgresqlFlexibleServer_createWithCustomerManagedKeyVersionless
=== PAUSE TestAccPostgresqlFlexibleServer_createWithCustomerManagedKeyVersionless
=== CONT  TestAccPostgresqlFlexibleServer_createWithCustomerManagedKey
=== CONT  TestAccPostgresqlFlexibleServer_createWithCustomerManagedKeyVersionless
--- PASS: TestAccPostgresqlFlexibleServer_createWithCustomerManagedKeyVersionless (687.47s)
--- PASS: TestAccPostgresqlFlexibleServer_createWithCustomerManagedKey (696.92s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/postgres      696.972s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_postgresql_flexible_server - Support versionless CMK key vault key id [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #29159

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@magodo magodo requested a review from a team as a code owner May 29, 2025 01:08
@magodo magodo changed the title azurerm_postgresql_flexible_server - Support versionless CMK key vault key id WIP: azurerm_postgresql_flexible_server - Support versionless CMK key vault key id May 29, 2025
@magodo magodo changed the title WIP: azurerm_postgresql_flexible_server - Support versionless CMK key vault key id azurerm_postgresql_flexible_server - Support versionless CMK key vault key id May 29, 2025
Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo, LGTM ✅

@sreallymatt sreallymatt merged commit a0c8c73 into hashicorp:main May 29, 2025
35 checks passed
@github-actions github-actions bot added this to the v4.32.0 milestone May 29, 2025
sreallymatt added a commit that referenced this pull request May 29, 2025
wyattfry pushed a commit that referenced this pull request Jun 5, 2025
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azurerm_key_vault_key: id and version field not correctly updating on new version

2 participants