[Bug:] azurerm_mssql_server_vulnerability_assessment - remove validation for storage_account_access_key and storage_container_sas_key being set

[WodansSon]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

When the storage account is secured behind a virtual network or firewall, it is valid for both storage_container_access_key and storage_container_sas_key to be unset. Accordingly, I am removing the validation logic that enforces the presence of at least one of these fields.

Error Message Consistency Across CRUD Operations:

All CRUD operations (Create, Read, Update, Delete) now have consistent error message patterns:

• Clear operation description
• Specific resource identification
• Proper error wrapping
• Actionable context when possible

Go Error Message Standards Compliance:

• Lowercase: All error messages now start with lowercase letters (unless they begin with proper nouns like "SQL")
• No punctuation: Removed periods and unnecessary punctuation from error messages
• Error wrapping: Used %w verb for proper error wrapping instead of %+v or %v

The error messages are now more professional, easier to understand for users, and follow Go's official error handling guidelines while maintaining the functional behavior.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_mssql_server_vulnerability_assessment - remove validation for storage_account_access_key and storage_container_sas_key fields being set [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #29767

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[catriona-m]

Thanks @WodansSon LGTM!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.