Skip to content

29694 -add vnet_route_all_enabled property for azurerm_function_app_flex_consumption#29839

Merged
catriona-m merged 2 commits intohashicorp:mainfrom
eltimmo:eltimmo---function-app-flex-vnet-route-all
Jun 23, 2025
Merged

29694 -add vnet_route_all_enabled property for azurerm_function_app_flex_consumption#29839
catriona-m merged 2 commits intohashicorp:mainfrom
eltimmo:eltimmo---function-app-flex-vnet-route-all

Conversation

@eltimmo
Copy link
Contributor

@eltimmo eltimmo commented Jun 11, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Add the add vnet_route_all_enabled property for the azurerm_function_app_flex_consumption resource

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

I added a basic test for VNET integration and the use of vnet_route_all_enabled

=== RUN   TestAccFunctionAppFlexConsumption_vNetIntegrationWithVnetProperties
=== PAUSE TestAccFunctionAppFlexConsumption_vNetIntegrationWithVnetProperties
=== CONT  TestAccFunctionAppFlexConsumption_vNetIntegrationWithVnetProperties
--- PASS: TestAccFunctionAppFlexConsumption_vNetIntegrationWithVnetProperties (314.70s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • [] Bug Fix
  • [] New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #29694

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eltimmo thanks for submitting this. This is looking good but I just had a couple of minor comments. Once those are addressed I can take another look. Thanks!

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eltimmo LGTM!

@catriona-m catriona-m merged commit 58a09ef into hashicorp:main Jun 23, 2025
35 checks passed
@github-actions github-actions bot added this to the v4.35.0 milestone Jun 23, 2025
catriona-m added a commit that referenced this pull request Jun 23, 2025
mbfrahry pushed a commit that referenced this pull request Jul 1, 2025
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for vnet_route_all_enabled in azurerm_function_app_flex_consumption

2 participants