Skip to content

azurerm_dev_center_dev_box_definition - add HibernateSupport (with hibernate_support_enabled property)#29995

Merged
sreallymatt merged 4 commits intohashicorp:mainfrom
shigeyf:main
Jul 9, 2025
Merged

azurerm_dev_center_dev_box_definition - add HibernateSupport (with hibernate_support_enabled property)#29995
sreallymatt merged 4 commits intohashicorp:mainfrom
shigeyf:main

Conversation

@shigeyf
Copy link
Contributor

@shigeyf shigeyf commented Jun 25, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_dev_center_dev_box_definition - support for the hibernate_support_enabled property

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #26703

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @shigeyf, I've left a couple minor comments inline, could you also add this new property to the documentation for both the resource and data source?

@shigeyf
Copy link
Contributor Author

shigeyf commented Jul 7, 2025

Thanks for opening this PR @shigeyf, I've left a couple minor comments inline, could you also add this new property to the documentation for both the resource and data source?

@sreallymatt - Thanks for taking a look for this PR. Updated per your suggestions!

@shigeyf
Copy link
Contributor Author

shigeyf commented Jul 8, 2025

Fixed linting errors.

Apologies for some confusions in this history.
I canceled merges on my forked repos (which was merging changes in the current refs/main) in order to reduce negative impacts that are not related with this PR.

Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes @shigeyf, 2 minor suggestions on the documentation, other than that this LGTM

Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shigeyf LGTM ✅

@sreallymatt sreallymatt merged commit 2e567cf into hashicorp:main Jul 9, 2025
36 checks passed
@github-actions github-actions bot added this to the v4.36.0 milestone Jul 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add hibernation support to azurerm_dev_center_dev_box_definition

2 participants