azurerm_virtual_network_gateway - Mark ip_configuration.public_ip_address_id as Optional#30038
Merged
catriona-m merged 3 commits intohashicorp:mainfrom Jul 1, 2025
Merged
Conversation
…ress_id as Optional
Collaborator
|
The test may fail in the West Europe region as the change is being rolled out. Please use West Central US for testing. |
Contributor
Author
|
@teowa , I updated to use "eastus2" for testing. --- PASS: TestAccVirtualNetworkGateway_withoutPublicIPAddressId (2106.83s) |
catriona-m
approved these changes
Jul 1, 2025
Member
catriona-m
left a comment
There was a problem hiding this comment.
Thanks @neil-yechenwei LGTM!
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This PR is to mark
ip_configuration.public_ip_address_idasOptionalfor supporting new feature.PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
--- PASS: TestAccVirtualNetworkGateway_withoutPublicIPAddressId (1563.14s)
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_virtual_network_gateway- Markip_configuration.public_ip_address_idasOptionalThis is a (please select all that apply):
Related Issue(s)
Fixes #30032
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.