Skip to content

feat(appservice): add support for PHP 8.4 in Linux#30281

Merged
catriona-m merged 1 commit intohashicorp:mainfrom
g-cadici:g-cadici/PHPVersionUpdate
Aug 4, 2025
Merged

feat(appservice): add support for PHP 8.4 in Linux#30281
catriona-m merged 1 commit intohashicorp:mainfrom
g-cadici:g-cadici/PHPVersionUpdate

Conversation

@g-cadici
Copy link
Contributor

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Adding support for PHP 8.4 in Linux Web Apps and Linux WebApp Slot
Updated documentation with new version support.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Linux Webapp test:

make acctests SERVICE='appservice' TESTARGS=' -run=TestAccLinuxWebApp_withPhp84' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccLinuxWebApp_withPhp84 -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccLinuxWebApp_withPhp84
=== PAUSE TestAccLinuxWebApp_withPhp84
=== CONT  TestAccLinuxWebApp_withPhp84

The test above builds the resource well with php 8.4

image

Linux WebApp Slot test:

make acctests SERVICE='appservice' TESTARGS=' -run=TestAccLinuxWebAppSlot_withPhp84' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccLinuxWebAppSlot_withPhp84 -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccLinuxWebAppSlot_withPhp84
=== PAUSE TestAccLinuxWebAppSlot_withPhp84
=== CONT  TestAccLinuxWebAppSlot_withPhp84

Resource created

image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the [Changelog Format documented here]

azurerm_linux_web_app - support for PHP 8.4
azurerm_linux_web_app_slot - support for PHP 8.4

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #30278

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @g-cadici LGTM!

@catriona-m catriona-m merged commit dd90836 into hashicorp:main Aug 4, 2025
34 checks passed
@github-actions github-actions bot added this to the v4.39.0 milestone Aug 4, 2025
catriona-m added a commit that referenced this pull request Aug 4, 2025
jackofallops pushed a commit that referenced this pull request Aug 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for PHP 8.4 in azurerm_linux_web_app application stack

2 participants