Skip to content

azurerm_linux_web_app - normalize docker url#30368

Merged
wyattfry merged 9 commits intomainfrom
wyatt/bug-docker-url-normalization
Aug 25, 2025
Merged

azurerm_linux_web_app - normalize docker url#30368
wyattfry merged 9 commits intomainfrom
wyatt/bug-docker-url-normalization

Conversation

@wyattfry
Copy link
Contributor

@wyattfry wyattfry commented Aug 11, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR normalizes the Docker Registry URL input, specifically removing any present trailing forward slash. This allows users to specify a URL with or without a trailing slash, whereas currently, trailing slashes were not accounted for and disrupted the string parsing producing incorrect results.

A test is added to ensure it can now accept URLs both with and without trailing slashes.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #20441

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@github-actions github-actions bot added size/XS and removed size/L labels Aug 11, 2025
@wyattfry wyattfry marked this pull request as ready for review August 11, 2025 19:39
@github-actions github-actions bot added the bug label Aug 11, 2025
@wyattfry wyattfry requested review from a team, WodansSon and magodo as code owners August 11, 2025 19:39
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wyattfry - LGTM 👍

@wyattfry wyattfry merged commit 47d2a4c into main Aug 25, 2025
50 checks passed
@wyattfry wyattfry deleted the wyatt/bug-docker-url-normalization branch August 25, 2025 14:26
@github-actions github-actions bot added this to the v4.42.0 milestone Aug 25, 2025
wyattfry added a commit that referenced this pull request Aug 25, 2025
mbfrahry pushed a commit that referenced this pull request Aug 28, 2025
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azurerm_linux_function_app adding / character to front of docker image_name

2 participants