azurerm_postgresql_flexible_server_firewall_rule - update the validation of start_ip_address and end_ip_address

[neil-yechenwei]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is to update the validation of start_ip_address and end_ip_address for postgresql fs firewall rule.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_postgresql_flexible_server_firewall_rule - update the validation of start_ip_address and end_ip_address

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #30488

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[sreallymatt]

Thanks @neil-yechenwei, I've just left a minor comment on how we can further improve the documentation while we're here

[sreallymatt]

Can we change IP V4 to IPv4, and while we're here, can we update the description to provide a little more detail? E.g. similar to REST API spec description:

Suggested change

	* `start_ip_address` - (Required) The Start IP V4 Address associated with this PostgreSQL Flexible Server Firewall Rule.
	* `start_ip_address` - (Required) The IPv4 Address defining the start of the range of addresses associated with this PostgreSQL Flexible Server Firewall Rule.

[neil-yechenwei]

Updated

[sreallymatt]

Same as above

Suggested change

	* `end_ip_address` - (Required) The End IP V4 Address associated with this PostgreSQL Flexible Server Firewall Rule.
	* `end_ip_address` - (Required) The IPv4 Address defining the end of the range of addresses associated with this PostgreSQL Flexible Server Firewall Rule.

[neil-yechenwei]

Updated

[neil-yechenwei]

@sreallymatt , thanks for the comments. I updated PR. Please take another look.

[sreallymatt]

Thanks @neil-yechenwei LGTM ✅

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.