`azurerm_subnet` - add support for `sharing_scope` by ms-zhenhua · Pull Request #30600 · hashicorp/terraform-provider-azurerm

ms-zhenhua · 2025-09-11T02:21:23Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

re-submit PR for PR 30316. Changes are:

The code, test and property doc description are the same with PR 30316.
Remove the limitation description from the Notes doc

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_subnet - support sharing_scope property

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

magodo · 2025-09-11T09:09:19Z

Other than the document, this PR LGTM!

Tests are passing:

mbfrahry

Thanks for opening this PR. Just a few comments but it looks good otherwise

mbfrahry · 2025-09-11T21:17:57Z

internal/services/network/subnet_resource.go

+				Type:     pluginsdk.TypeString,
+				Optional: true,
+				// now only "Tenant" is supported, "DelegatedServices" is not supported, https://github.com/Azure/azure-rest-api-specs/issues/36446
+				ValidateFunc: validation.StringInSlice([]string{"Tenant"}, false),


Suggested change

ValidateFunc: validation.StringInSlice([]string{"Tenant"}, false),

ValidateFunc: validation.StringInSlice([]string{subnets.SharingScopeTenant}, false),

Updated. Thanks.

mbfrahry · 2025-09-11T21:18:22Z

internal/services/network/subnet_resource.go

 	serviceEndpointsRaw := d.Get("service_endpoints").(*pluginsdk.Set).List()
 	properties.ServiceEndpoints = expandSubnetServiceEndpoints(serviceEndpointsRaw)

+	properties.SharingScope = pointer.To(subnets.SharingScope(d.Get("sharing_scope").(string)))


Suggested change

properties.SharingScope = pointer.To(subnets.SharingScope(d.Get("sharing_scope").(string)))

properties.SharingScope = pointer.ToEnum[subnets.SharingScope](d.Get("sharing_scope").(string))

Since Go generic currently can't infer the type from the LHS in an assignment statement, we have to explicitly specify the generic type as above. Wondering what is the benefit of using the ToEnum comparing to the To..

Updated. Thanks.

mbfrahry · 2025-09-11T21:32:22Z

website/docs/r/subnet.html.markdown


+* `sharing_scope` - (Optional) The sharing scope of the subnet. Possible value is `Tenant`. This property cannot be set if `default_outbound_access_enabled` is set to `true`.
+
+!> **Note:** The `sharing_scope` property is only available to users who have been explicitly registered and granted access by the Azure Networking Product Group.


I believe this note is unneeded

Suggested change

!> **Note:** The `sharing_scope` property is only available to users who have been explicitly registered and granted access by the Azure Networking Product Group.

Updated. Thanks.

Apologies for the back and forth. This line is needed here

No worries. Added back.

mbfrahry · 2025-09-11T21:33:08Z

website/docs/r/subnet.html.markdown


 -> **Note:** When configuring Azure Private Link service, the explicit setting `private_link_service_network_policies_enabled` must be set to `false` in the subnet since Private Link Service does not support network policies like user-defined Routes and Network Security Groups. This setting only affects the Private Link service. For other resources in the subnet, access is controlled based on the Network Security Group which can be configured using the `azurerm_subnet_network_security_group_association` resource. See more details from [Manage network policies for Private Link Services](https://learn.microsoft.com/en-gb/azure/private-link/disable-private-link-service-network-policy?tabs=private-link-network-policy-powershell).

+* `sharing_scope` - (Optional) The sharing scope of the subnet. Possible value is `Tenant`. This property cannot be set if `default_outbound_access_enabled` is set to `true`.


Suggested change

* `sharing_scope` - (Optional) The sharing scope of the subnet. Possible value is `Tenant`. This property cannot be set if `default_outbound_access_enabled` is set to `true`.

* `sharing_scope` - (Optional) The sharing scope of the subnet. Possible value is `Tenant`.

~> **Note:** This property cannot be set if `default_outbound_access_enabled` is set to `true`.

Updated. Thanks.

mbfrahry · 2025-09-11T21:33:46Z

internal/services/network/subnet_resource_test.go

 	})
 }

+func TestAccSubnet_sharingScope(t *testing.T) {


This test can be removed as it's captured by TestAccSubnet_sharingScopeUpdated

Updated. Thanks

mbfrahry · 2025-09-11T21:34:22Z

internal/services/network/subnet_resource.go

+			"sharing_scope": {
+				Type:     pluginsdk.TypeString,
+				Optional: true,
+				// now only "Tenant" is supported, "DelegatedServices" is not supported, https://github.com/Azure/azure-rest-api-specs/issues/36446


Suggested change

// now only "Tenant" is supported, "DelegatedServices" is not supported, https://github.com/Azure/azure-rest-api-specs/issues/36446

// todo "Tenant" is only supported until https://github.com/Azure/azure-rest-api-specs/issues/36446 is addressed

Updated. Thanks.

ms-zhenhua · 2025-09-12T05:18:59Z

Hi @mbfrahry , thanks for the review. I have updated the code and doc. Kindly help take another look.

ms-zhenhua · 2025-09-15T05:20:51Z

Hi @mbfrahry, I have added the Note back. Kindly take another review.

mbfrahry

LGTM!

github-actions · 2025-10-16T02:16:28Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

support sharing_scope for azurerm_subnet

7ded154

github-actions bot added enhancement documentation service/network size/M labels Sep 11, 2025

ms-zhenhua marked this pull request as ready for review September 11, 2025 05:49

ms-zhenhua requested review from a team, WodansSon and magodo as code owners September 11, 2025 05:49

update docs/r/subnet.html.markdown

6a9ba87

magodo self-assigned this Sep 11, 2025

mybayern1974 unassigned magodo Sep 11, 2025

mbfrahry requested changes Sep 11, 2025

View reviewed changes

github-actions bot assigned mbfrahry Sep 11, 2025

github-actions bot added the waiting-response label Sep 11, 2025

resolved comments

eaf9a99

github-actions bot removed the waiting-response label Sep 12, 2025

ms-zhenhua added 2 commits September 12, 2025 11:02

resolved comments

40ef069

resolved comments

8ef9c8d

ms-zhenhua requested a review from mbfrahry September 12, 2025 05:19

github-actions bot added the waiting-response label Sep 12, 2025

resolved comments

ebff271

github-actions bot removed the waiting-response label Sep 15, 2025

mbfrahry approved these changes Sep 15, 2025

View reviewed changes

mbfrahry added this to the v4.45.0 milestone Sep 15, 2025

mbfrahry changed the title ~~azurerm_subnet - support sharing_scope property~~ azurerm_subnet - add support for sharing_scope Sep 15, 2025

mbfrahry merged commit 8c78c9f into hashicorp:main Sep 15, 2025
35 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2025

	ValidateFunc: validation.StringInSlice([]string{"Tenant"}, false),
	ValidateFunc: validation.StringInSlice([]string{subnets.SharingScopeTenant}, false),

	properties.SharingScope = pointer.To(subnets.SharingScope(d.Get("sharing_scope").(string)))
	properties.SharingScope = pointer.ToEnum[subnets.SharingScope](d.Get("sharing_scope").(string))


		* `sharing_scope` - (Optional) The sharing scope of the subnet. Possible value is `Tenant`. This property cannot be set if `default_outbound_access_enabled` is set to `true`.

		!> Note: The `sharing_scope` property is only available to users who have been explicitly registered and granted access by the Azure Networking Product Group.


		-> Note: When configuring Azure Private Link service, the explicit setting `private_link_service_network_policies_enabled` must be set to `false` in the subnet since Private Link Service does not support network policies like user-defined Routes and Network Security Groups. This setting only affects the Private Link service. For other resources in the subnet, access is controlled based on the Network Security Group which can be configured using the `azurerm_subnet_network_security_group_association` resource. See more details from [Manage network policies for Private Link Services](https://learn.microsoft.com/en-gb/azure/private-link/disable-private-link-service-network-policy?tabs=private-link-network-policy-powershell).

		* `sharing_scope` - (Optional) The sharing scope of the subnet. Possible value is `Tenant`. This property cannot be set if `default_outbound_access_enabled` is set to `true`.

	// now only "Tenant" is supported, "DelegatedServices" is not supported, https://github.com/Azure/azure-rest-api-specs/issues/36446
	// todo "Tenant" is only supported until https://github.com/Azure/azure-rest-api-specs/issues/36446 is addressed

Conversation

ms-zhenhua commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

Rollback Plan

Changes to Security Controls

Uh oh!

magodo commented Sep 11, 2025

Uh oh!

mbfrahry left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ms-zhenhua commented Sep 12, 2025

Uh oh!

ms-zhenhua commented Sep 15, 2025

Uh oh!

mbfrahry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ms-zhenhua commented Sep 11, 2025 •

edited

Loading