azurerm_resource_group refactor onto go-azure-sdk and add Resource Identity#30616
Merged
jackofallops merged 11 commits intomainfrom Nov 19, 2025
Merged
azurerm_resource_group refactor onto go-azure-sdk and add Resource Identity#30616jackofallops merged 11 commits intomainfrom
azurerm_resource_group refactor onto go-azure-sdk and add Resource Identity#30616jackofallops merged 11 commits intomainfrom
Conversation
github-actions
bot
added
size/L
waiting-response
size/XL
and removed
waiting-response
size/L
labels
jackofallops
changed the title
azurerm_resource_group refactor onto go-azure-sdk and add Resource Identityazurerm_resource_group refactor onto go-azure-sdk and add Resource Identity
jackofallops
requested review from
a team,
WodansSon and
magodo
as code owners
Member
Author
|
sreallymatt
requested changes
Sep 16, 2025
Collaborator
sreallymatt
left a comment
sreallymatt
left a comment
There was a problem hiding this comment.
Thanks @jackofallops, I've just got a couple comments
sreallymatt
reviewed
Sep 16, 2025
internal/services/resource/custompollers/resource_group_create_poller.go
Outdated
Show resolved
Hide resolved
…urces that may have lower case resourcegroups segment
jackofallops
force-pushed
the
deps/resource_group_sdk_bump
branch
from
1bb44b5 to
6187ad4
Compare
sreallymatt
approved these changes
Sep 17, 2025
Collaborator
sreallymatt
left a comment
sreallymatt
left a comment
There was a problem hiding this comment.
Thanks @jackofallops LGTM ✅
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## Description
This PR updates the SDK used by
azurerm_resource_grouptogo-azure-sdkand refactors several legacy implementations to current standards. This is necessary for upcoming changes and features.Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.