`azurerm_netapp_volume`, `azurerm_netapp_volume_group_oracle`, `azurerm_netapp_volume_group_sap_hana` - add support for updating `protocols` by paulomarquesc · Pull Request #30643 · hashicorp/terraform-provider-azurerm

paulomarquesc · 2025-09-17T23:56:50Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR implements support for converting volume protocols from NFSv3 to NFSv4.1 and vice versa and impacts the following resources:

azurerm_netapp_volume
azurerm_netapp_volume_group_oracle
azurerm_netapp_volume_group_sap_hana

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Unit Tests

pmarques [ ~/go/src/github.com/hashicorp/terraform-provider-azurerm ]$ cd /home/pmarques/go/src/github.com/hashicorp/terraform-provider-azurerm && go test -v ./internal/services/netapp/validate/ -count=1 -timeout 60s
=== RUN   TestDataFlowID
    account_id_test.go:68: [DEBUG] Testing Value 
    account_id_test.go:68: [DEBUG] Testing Value /
    account_id_test.go:68: [DEBUG] Testing Value /subscriptions/
    account_id_test.go:68: [DEBUG] Testing Value /subscriptions/12345678-1234-9876-4563-123456789012/
    account_id_test.go:68: [DEBUG] Testing Value /subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/
    account_id_test.go:68: [DEBUG] Testing Value /subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/resGroup1/providers/Microsoft.NetApp/
    account_id_test.go:68: [DEBUG] Testing Value /subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/resGroup1/providers/Microsoft.NetApp/netAppAccounts/
    account_id_test.go:68: [DEBUG] Testing Value /subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/resGroup1/providers/Microsoft.NetApp/netAppAccounts/account1
    account_id_test.go:68: [DEBUG] Testing Value /SUBSCRIPTIONS/12345678-1234-9876-4563-123456789012/RESOURCEGROUPS/RESGROUP1/PROVIDERS/MICROSOFT.NETAPP/NETAPPACCOUNTS/ACCOUNT1
--- PASS: TestDataFlowID (0.00s)
=== RUN   TestValidateNetAppBackupPolicyCombinedRetention
=== RUN   TestValidateNetAppBackupPolicyCombinedRetention/ValidateCombinedRetentionWithValidValues
=== RUN   TestValidateNetAppBackupPolicyCombinedRetention/ValidateCombinedRetentionWithValidValuesMaximumReachedFailure
--- PASS: TestValidateNetAppBackupPolicyCombinedRetention (0.00s)
    --- PASS: TestValidateNetAppBackupPolicyCombinedRetention/ValidateCombinedRetentionWithValidValues (0.00s)
    --- PASS: TestValidateNetAppBackupPolicyCombinedRetention/ValidateCombinedRetentionWithValidValuesMaximumReachedFailure (0.00s)
=== RUN   TestSnapshotName
    snapshot_name_test.go:66: [DEBUG] Testing ""..
    snapshot_name_test.go:66: [DEBUG] Testing "hello"..
    snapshot_name_test.go:66: [DEBUG] Testing "_hello"..
    snapshot_name_test.go:66: [DEBUG] Testing "hello-"..
    snapshot_name_test.go:66: [DEBUG] Testing "hello!"..
    snapshot_name_test.go:66: [DEBUG] Testing "malcolm-in-the-middle"..
    snapshot_name_test.go:66: [DEBUG] Testing "hello."..
    snapshot_name_test.go:66: [DEBUG] Testing "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijk"..
    snapshot_name_test.go:66: [DEBUG] Testing "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijkj"..
    snapshot_name_test.go:66: [DEBUG] Testing "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijkja"..
--- PASS: TestSnapshotName (0.00s)
=== RUN   TestNetAppVolumeGroupName
    volume_group_name_test.go:66: [DEBUG] Testing ""..
    volume_group_name_test.go:66: [DEBUG] Testing "hello"..
    volume_group_name_test.go:66: [DEBUG] Testing "_hello"..
    volume_group_name_test.go:66: [DEBUG] Testing "hello-"..
    volume_group_name_test.go:66: [DEBUG] Testing "hello!"..
    volume_group_name_test.go:66: [DEBUG] Testing "malcolm-in-the-middle"..
    volume_group_name_test.go:66: [DEBUG] Testing "hello."..
    volume_group_name_test.go:66: [DEBUG] Testing "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijk"..
    volume_group_name_test.go:66: [DEBUG] Testing "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijkj"..
    volume_group_name_test.go:66: [DEBUG] Testing "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijkja"..
--- PASS: TestNetAppVolumeGroupName (0.00s)
=== RUN   TestValidateNetAppVolumeGroupOracleProtocolConversion
=== RUN   TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionDataNFSv3ToNFSv41
=== RUN   TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionDataNFSv41ToNFSv3
=== RUN   TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionLogsNFSv3ToNFSv41
=== RUN   TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionLogsNFSv41ToNFSv3
=== RUN   TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionBinaryNFSv3ToNFSv41
=== RUN   TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionBinaryNFSv41ToNFSv3
=== RUN   TestValidateNetAppVolumeGroupOracleProtocolConversion/NoChangeNoValidation
=== RUN   TestValidateNetAppVolumeGroupOracleProtocolConversion/InitialCreationNoValidation
=== RUN   TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionWithMatchingExportPolicy
=== RUN   TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionWithExportPolicyUpdate
=== RUN   TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionMultipleVolumes
=== RUN   TestValidateNetAppVolumeGroupOracleProtocolConversion/InvalidDualProtocolConversion
=== RUN   TestValidateNetAppVolumeGroupOracleProtocolConversion/InvalidCIFSConversion
=== RUN   TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidCustomVolumeSpecName
--- PASS: TestValidateNetAppVolumeGroupOracleProtocolConversion (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionDataNFSv3ToNFSv41 (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionDataNFSv41ToNFSv3 (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionLogsNFSv3ToNFSv41 (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionLogsNFSv41ToNFSv3 (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionBinaryNFSv3ToNFSv41 (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionBinaryNFSv41ToNFSv3 (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleProtocolConversion/NoChangeNoValidation (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleProtocolConversion/InitialCreationNoValidation (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionWithMatchingExportPolicy (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionWithExportPolicyUpdate (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidConversionMultipleVolumes (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleProtocolConversion/InvalidDualProtocolConversion (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleProtocolConversion/InvalidCIFSConversion (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleProtocolConversion/ValidCustomVolumeSpecName (0.00s)
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleOracle
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateNFSv41EnabledOnNFSv41Volume
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateNFSv3EnabledOnNFSv3Volume
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateBothProtocolsNotEnabledAtSameTimeOnNFSv41Volume
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateBothProtocolsNotEnabledAtSameTimeOnNFSv3Volume
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateBothProtocolsNotDisabledAtSameTimeOnNFSv3Volume
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateBothProtocolsNotDisabledAtSameTimeOnNFSv41Volume
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateNFSv3NotEnabledOnNFSv41Volume
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateNFSv41NotEnabledOnNFSv3Volume
--- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleOracle (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateNFSv41EnabledOnNFSv41Volume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateNFSv3EnabledOnNFSv3Volume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateBothProtocolsNotEnabledAtSameTimeOnNFSv41Volume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateBothProtocolsNotEnabledAtSameTimeOnNFSv3Volume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateBothProtocolsNotDisabledAtSameTimeOnNFSv3Volume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateBothProtocolsNotDisabledAtSameTimeOnNFSv41Volume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateNFSv3NotEnabledOnNFSv41Volume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleOracle/ValidateNFSv41NotEnabledOnNFSv3Volume (0.00s)
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateCorrectSettingsAllVolumesPPG
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateCorrectSettingsAllVolumesAvailabilityZone
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateCorrectSettingsAllVolumesProximityPlacementGroup
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateCorrectSettingsAllVolumesProximityPlacementGroupFailsWhenDifferent
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidatePPGAndAvailabilityZoneNotSetAtSameTime
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateMinimumVolumes
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateVolumesSameZone
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateVolumesNotSameZoneErrors
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateRequiredVolumeSpecs
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateLessThanMinimumVolumes
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateMultiProtocolFails
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateNoProtocolFails
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateInvalidProtocolList
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateInvalidProtocol
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateCIFSInvalidProtocolForOracle
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateVolumeSpecCantRepeat
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateCustomerManagedKeyOptionsAreSetTogether
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateCustomerManagedKeyOptionsNotSetTogetherFailsWhenKeyVault
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateCustomerManagedKeyNotSameAllVolumesFails
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidatePlatformManagedKey
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateCustomerManagedKeyFailsOnBasicNetworkFeatures
=== RUN   TestValidateNetAppVolumeGroupOracleVolumes/ValidateCustomerManagedKeyPassOnStandardNetworkFeatures
--- PASS: TestValidateNetAppVolumeGroupOracleVolumes (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateCorrectSettingsAllVolumesPPG (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateCorrectSettingsAllVolumesAvailabilityZone (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateCorrectSettingsAllVolumesProximityPlacementGroup (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateCorrectSettingsAllVolumesProximityPlacementGroupFailsWhenDifferent (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidatePPGAndAvailabilityZoneNotSetAtSameTime (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateMinimumVolumes (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateVolumesSameZone (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateVolumesNotSameZoneErrors (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateRequiredVolumeSpecs (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateLessThanMinimumVolumes (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateMultiProtocolFails (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateNoProtocolFails (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateInvalidProtocolList (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateInvalidProtocol (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateCIFSInvalidProtocolForOracle (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateVolumeSpecCantRepeat (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateCustomerManagedKeyOptionsAreSetTogether (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateCustomerManagedKeyOptionsNotSetTogetherFailsWhenKeyVault (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateCustomerManagedKeyNotSameAllVolumesFails (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidatePlatformManagedKey (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateCustomerManagedKeyFailsOnBasicNetworkFeatures (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupOracleVolumes/ValidateCustomerManagedKeyPassOnStandardNetworkFeatures (0.00s)
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidNFSv41OnDataVolume
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidNFSv41OnLogVolume
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidNFSv41OnSharedVolume
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidNFSv3OnDataBackupVolume
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidNFSv3OnLogBackupVolume
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidNFSv41OnDataBackupVolume
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidNFSv41OnLogBackupVolume
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/InvalidNFSv3OnDataVolume
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/InvalidNFSv3OnLogVolume
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/InvalidNFSv3OnSharedVolume
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/InvalidNFSv3WithNFSv41OnDataVolume
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/InvalidNFSv3WithNFSv41OnLogVolume
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/InvalidNFSv3WithNFSv41OnSharedVolume
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidOtherVolumeSpecWithNFSv3
--- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidNFSv41OnDataVolume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidNFSv41OnLogVolume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidNFSv41OnSharedVolume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidNFSv3OnDataBackupVolume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidNFSv3OnLogBackupVolume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidNFSv41OnDataBackupVolume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidNFSv41OnLogBackupVolume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/InvalidNFSv3OnDataVolume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/InvalidNFSv3OnLogVolume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/InvalidNFSv3OnSharedVolume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/InvalidNFSv3WithNFSv41OnDataVolume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/InvalidNFSv3WithNFSv41OnLogVolume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/InvalidNFSv3WithNFSv41OnSharedVolume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolRestrictions/ValidOtherVolumeSpecWithNFSv3 (0.00s)
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolConversion
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/ValidConversionDataBackupNFSv3ToNFSv41
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/ValidConversionLogBackupNFSv41ToNFSv3
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/ValidConversionDataVolumeNFSv41ToNFSv41
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/InvalidConversionDataVolumeToNFSv3
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/InvalidConversionLogVolumeToNFSv3
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/InvalidConversionSharedVolumeToNFSv3
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/ValidConversionWithExportPolicy
=== RUN   TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/NoConversionNoValidation
--- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolConversion (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/ValidConversionDataBackupNFSv3ToNFSv41 (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/ValidConversionLogBackupNFSv41ToNFSv3 (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/ValidConversionDataVolumeNFSv41ToNFSv41 (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/InvalidConversionDataVolumeToNFSv3 (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/InvalidConversionLogVolumeToNFSv3 (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/InvalidConversionSharedVolumeToNFSv3 (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/ValidConversionWithExportPolicy (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaProtocolConversion/NoConversionNoValidation (0.00s)
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateNFSv41EnabledOnNFSv41Volume
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateNFSv3EnabledOnNFSv3Volume
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateBothProtocolsNotEnabledAtSameTimeOnNFSv41Volume
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateBothProtocolsNotEnabledAtSameTimeOnNFSv3Volume
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateBothProtocolsNotDisabledAtSameTimeOnNFSv3Volume
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateBothProtocolsNotDisabledAtSameTimeOnNFSv41Volume
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateNFSv3NotEnabledOnNFSv41Volume
=== RUN   TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateNFSv41NotEnabledOnNFSv3Volume
--- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateNFSv41EnabledOnNFSv41Volume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateNFSv3EnabledOnNFSv3Volume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateBothProtocolsNotEnabledAtSameTimeOnNFSv41Volume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateBothProtocolsNotEnabledAtSameTimeOnNFSv3Volume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateBothProtocolsNotDisabledAtSameTimeOnNFSv3Volume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateBothProtocolsNotDisabledAtSameTimeOnNFSv41Volume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateNFSv3NotEnabledOnNFSv41Volume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupExportPolicyRuleSAPHana/ValidateNFSv41NotEnabledOnNFSv3Volume (0.00s)
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateCorrectSettingsAllVolumes
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateMinimumVolumes
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateRequiredVolumeSpecs
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateLessThanMinimumVolumes
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateMultiProtocolFails
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateNoProtocolFails
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateInvalidProtocolList
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateInvalidProtocol
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateCIFSInvalidProtocolForSAPHana
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateNoNfsVersionThreeOnDataLogAndSharedVolumes
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateNoPPGBackupVolumes
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateRequiredPpgForNonBackupVolumes
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateVolumeSpecCantRepeat
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateEndpointDstNotEnabledOnLogVolume
=== RUN   TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateSnapshotPolicyNotEnabledOnEndpointDstVolume
--- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateCorrectSettingsAllVolumes (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateMinimumVolumes (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateRequiredVolumeSpecs (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateLessThanMinimumVolumes (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateMultiProtocolFails (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateNoProtocolFails (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateInvalidProtocolList (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateInvalidProtocol (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateCIFSInvalidProtocolForSAPHana (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateNoNfsVersionThreeOnDataLogAndSharedVolumes (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateNoPPGBackupVolumes (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateRequiredPpgForNonBackupVolumes (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateVolumeSpecCantRepeat (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateEndpointDstNotEnabledOnLogVolume (0.00s)
    --- PASS: TestValidateNetAppVolumeGroupSAPHanaVolumes/ValidateSnapshotPolicyNotEnabledOnEndpointDstVolume (0.00s)
=== RUN   TestNetAppVolumeName
    volume_name_test.go:66: [DEBUG] Testing ""..
    volume_name_test.go:66: [DEBUG] Testing "hello"..
    volume_name_test.go:66: [DEBUG] Testing "_hello"..
    volume_name_test.go:66: [DEBUG] Testing "hello-"..
    volume_name_test.go:66: [DEBUG] Testing "hello!"..
    volume_name_test.go:66: [DEBUG] Testing "malcolm-in-the-middle"..
    volume_name_test.go:66: [DEBUG] Testing "hello."..
    volume_name_test.go:66: [DEBUG] Testing "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijk"..
    volume_name_test.go:66: [DEBUG] Testing "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijkj"..
    volume_name_test.go:66: [DEBUG] Testing "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijkja"..
--- PASS: TestNetAppVolumeName (0.00s)
=== RUN   TestVolumePath
    volume_path_test.go:66: [DEBUG] Testing ""..
    volume_path_test.go:66: [DEBUG] Testing "hello"..
    volume_path_test.go:66: [DEBUG] Testing "_hello"..
    volume_path_test.go:66: [DEBUG] Testing "hello-"..
    volume_path_test.go:66: [DEBUG] Testing "hello!"..
    volume_path_test.go:66: [DEBUG] Testing "malcolm-in-the-middle"..
    volume_path_test.go:66: [DEBUG] Testing "hello."..
    volume_path_test.go:66: [DEBUG] Testing "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijabcdefgheysudciac"..
    volume_path_test.go:66: [DEBUG] Testing "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijkasbdjdssardwyupac"..
    volume_path_test.go:66: [DEBUG] Testing "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijkjspoiuytrewqasdfac"..
--- PASS: TestVolumePath (0.00s)
=== RUN   TestValidateNetAppVolumeProtocolConversion
=== RUN   TestValidateNetAppVolumeProtocolConversion/ValidConversionNFSv3ToNFSv41
=== RUN   TestValidateNetAppVolumeProtocolConversion/ValidConversionNFSv41ToNFSv3
=== RUN   TestValidateNetAppVolumeProtocolConversion/NoChangeNoValidation
=== RUN   TestValidateNetAppVolumeProtocolConversion/InitialCreationNoValidation
=== RUN   TestValidateNetAppVolumeProtocolConversion/InvalidKerberosNFSv41ToNFSv3Conversion
=== RUN   TestValidateNetAppVolumeProtocolConversion/InvalidDualProtocolConversionOld
=== RUN   TestValidateNetAppVolumeProtocolConversion/InvalidDualProtocolConversionNew
=== RUN   TestValidateNetAppVolumeProtocolConversion/InvalidCIFSConversionOld
=== RUN   TestValidateNetAppVolumeProtocolConversion/InvalidCIFSConversionNew
=== RUN   TestValidateNetAppVolumeProtocolConversion/InvalidCIFSToDualProtocol
=== RUN   TestValidateNetAppVolumeProtocolConversion/InvalidDestinationVolumeConversion
=== RUN   TestValidateNetAppVolumeProtocolConversion/ValidSourceVolumeConversion
=== RUN   TestValidateNetAppVolumeProtocolConversion/ValidExportPolicyDuringProtocolConversion
=== RUN   TestValidateNetAppVolumeProtocolConversion/ValidExportPolicyWithProtocolsEnabledDuringConversion
=== RUN   TestValidateNetAppVolumeProtocolConversion/ValidExportPolicyProtocolMatchWithProtocolField
=== RUN   TestValidateNetAppVolumeProtocolConversion/ValidExportPolicyProtocolMatchWithProtocolsEnabledField
--- PASS: TestValidateNetAppVolumeProtocolConversion (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/ValidConversionNFSv3ToNFSv41 (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/ValidConversionNFSv41ToNFSv3 (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/NoChangeNoValidation (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/InitialCreationNoValidation (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/InvalidKerberosNFSv41ToNFSv3Conversion (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/InvalidDualProtocolConversionOld (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/InvalidDualProtocolConversionNew (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/InvalidCIFSConversionOld (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/InvalidCIFSConversionNew (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/InvalidCIFSToDualProtocol (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/InvalidDestinationVolumeConversion (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/ValidSourceVolumeConversion (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/ValidExportPolicyDuringProtocolConversion (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/ValidExportPolicyWithProtocolsEnabledDuringConversion (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/ValidExportPolicyProtocolMatchWithProtocolField (0.00s)
    --- PASS: TestValidateNetAppVolumeProtocolConversion/ValidExportPolicyProtocolMatchWithProtocolsEnabledField (0.00s)
=== RUN   TestNetAppVolumeQuotaRuleName
    volume_quota_rule_name_test.go:66: [DEBUG] Testing ""..
    volume_quota_rule_name_test.go:66: [DEBUG] Testing "hello"..
    volume_quota_rule_name_test.go:66: [DEBUG] Testing "_hello"..
    volume_quota_rule_name_test.go:66: [DEBUG] Testing "hello-"..
    volume_quota_rule_name_test.go:66: [DEBUG] Testing "hello!"..
    volume_quota_rule_name_test.go:66: [DEBUG] Testing "malcolm-in-the-middle"..
    volume_quota_rule_name_test.go:66: [DEBUG] Testing "hello."..
    volume_quota_rule_name_test.go:66: [DEBUG] Testing "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijk"..
    volume_quota_rule_name_test.go:66: [DEBUG] Testing "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijkj"..
    volume_quota_rule_name_test.go:66: [DEBUG] Testing "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijkja"..
--- PASS: TestNetAppVolumeQuotaRuleName (0.00s)
=== RUN   TestValidateNetAppVolumeQuotaRulesUnix
=== RUN   TestValidateNetAppVolumeQuotaRulesUnix/ValidateCorrectUnixUserGroupID
=== RUN   TestValidateNetAppVolumeQuotaRulesUnix/ValidateUnixUserGroupIDWithLettersFail
=== RUN   TestValidateNetAppVolumeQuotaRulesUnix/ValidateUnixUserGroupIDWithMoreThanMaxCharsFail
=== RUN   TestValidateNetAppVolumeQuotaRulesUnix/ValidateUnixUserGroupIDWithEmptyStringFail
=== RUN   TestValidateNetAppVolumeQuotaRulesUnix/ValidateUnixUserGroupIDWithNegativeNumberFail
--- PASS: TestValidateNetAppVolumeQuotaRulesUnix (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRulesUnix/ValidateCorrectUnixUserGroupID (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRulesUnix/ValidateUnixUserGroupIDWithLettersFail (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRulesUnix/ValidateUnixUserGroupIDWithMoreThanMaxCharsFail (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRulesUnix/ValidateUnixUserGroupIDWithEmptyStringFail (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRulesUnix/ValidateUnixUserGroupIDWithNegativeNumberFail (0.00s)
=== RUN   TestValidateNetAppVolumeQuotaRules
=== RUN   TestValidateNetAppVolumeQuotaRules/ValidateCorrectWindowsUserIDLong
=== RUN   TestValidateNetAppVolumeQuotaRules/ValidateCorrectWindowsGroupIDLong
=== RUN   TestValidateNetAppVolumeQuotaRules/ValidateCorrectWindowsGroupIDShort
=== RUN   TestValidateNetAppVolumeQuotaRules/ValidateCorrectWindowsGroupIDExtraShort
=== RUN   TestValidateNetAppVolumeQuotaRules/ValidateIncorrectWindowsUserIDLongFails
=== RUN   TestValidateNetAppVolumeQuotaRules/ValidateIncorrectWindowsGroupIDLongFails
=== RUN   TestValidateNetAppVolumeQuotaRules/ValidateIncorrectWindowsGroupIDShortFails
=== RUN   TestValidateNetAppVolumeQuotaRules/ValidateIncorrectWindowsGroupIDExtraShortFails
--- PASS: TestValidateNetAppVolumeQuotaRules (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRules/ValidateCorrectWindowsUserIDLong (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRules/ValidateCorrectWindowsGroupIDLong (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRules/ValidateCorrectWindowsGroupIDShort (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRules/ValidateCorrectWindowsGroupIDExtraShort (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRules/ValidateIncorrectWindowsUserIDLongFails (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRules/ValidateIncorrectWindowsGroupIDLongFails (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRules/ValidateIncorrectWindowsGroupIDShortFails (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRules/ValidateIncorrectWindowsGroupIDExtraShortFails (0.00s)
=== RUN   TestValidateNetAppVolumeQuotaRulesQuotaType
=== RUN   TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateIndividualUserQuotaTargetIsDefined
=== RUN   TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateIndividualGroupQuotaTargetIsDefined
=== RUN   TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateDefaultUserQuotaTargetIsNotDefined
=== RUN   TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateIndividualGroupQuotaTargetIsNotDefined
=== RUN   TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateIndividualUserQuotaTargetIsDefinedFailsWhenMissingTarget
=== RUN   TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateIndividualGroupQuotaTargetIsDefinedFailsWhenMissingTarget
=== RUN   TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateDefaultUserQuotaTargetFailsWhenDefiningTarget
=== RUN   TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateIndividualGroupQuotaTargetFailsWhenDefiningTarget
--- PASS: TestValidateNetAppVolumeQuotaRulesQuotaType (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateIndividualUserQuotaTargetIsDefined (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateIndividualGroupQuotaTargetIsDefined (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateDefaultUserQuotaTargetIsNotDefined (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateIndividualGroupQuotaTargetIsNotDefined (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateIndividualUserQuotaTargetIsDefinedFailsWhenMissingTarget (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateIndividualGroupQuotaTargetIsDefinedFailsWhenMissingTarget (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateDefaultUserQuotaTargetFailsWhenDefiningTarget (0.00s)
    --- PASS: TestValidateNetAppVolumeQuotaRulesQuotaType/ValidateIndividualGroupQuotaTargetFailsWhenDefiningTarget (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp/validate       0.026s

Acceptance tests with imapcted resources

pmarques [ ~/go/src/github.com/hashicorp/terraform-provider-azurerm ]$ make acctests SERVICE='netapp' TESTARGS=' -parallel 1 -run=TestAccNetAppVolumeGroupOracle_protocolConversion -count=1' TESTTIMEOUT='1200m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupOracle_protocolConversion -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupOracle_protocolConversion
=== PAUSE TestAccNetAppVolumeGroupOracle_protocolConversion
=== CONT  TestAccNetAppVolumeGroupOracle_protocolConversion
--- PASS: TestAccNetAppVolumeGroupOracle_protocolConversion (1604.57s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp        1604.603s


pmarques [ ~/go/src/github.com/hashicorp/terraform-provider-azurerm ]$ make acctests SERVICE='netapp' TESTARGS=' -parallel 1 -run=TestAccNetAppVolume_update -count=1' TESTTIMEOUT='1200m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolume_update -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolume_update
=== PAUSE TestAccNetAppVolume_update
=== RUN   TestAccNetAppVolume_updateExportPolicyRule
=== PAUSE TestAccNetAppVolume_updateExportPolicyRule
=== CONT  TestAccNetAppVolume_update
--- PASS: TestAccNetAppVolume_update (1030.85s)
=== CONT  TestAccNetAppVolume_updateExportPolicyRule
--- PASS: TestAccNetAppVolume_updateExportPolicyRule (1042.03s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp        2072.914s

pmarques [ ~/go/src/github.com/hashicorp/terraform-provider-azurerm ]$ make acctests SERVICE='netapp' TESTARGS=' -parallel 1 -run=TestAccNetAppVolume_basic -count=1' TESTTIMEOUT='1200m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolume_basic -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolume_basic
=== PAUSE TestAccNetAppVolume_basic
=== CONT  TestAccNetAppVolume_basic
--- PASS: TestAccNetAppVolume_basic (869.15s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp        869.188s

(reverse-i-search)`cd ': ^C /home/pmarques/go/src/github.com/hashicorp/terraform-provider-azurerm && make acctests SERVICE='netapp' TESTARGS=' -parallel 1 -run=TestAccNetAppVolume_protocolConversion -count=1' TESTTIMEOUT='1200m'
pmarques [ ~ ]$ cd ~/go/src/github.com/hashicorp/terraform-provider-azurerm
pmarques [ ~/go/src/github.com/hashicorp/terraform-provider-azurerm ]$ go build
pmarques [ ~/go/src/github.com/hashicorp/terraform-provider-azurerm ]$ go build
pmarques [ ~/go/src/github.com/hashicorp/terraform-provider-azurerm ]$ make acctests SERVICE='netapp' TESTARGS=' -parallel 1 -run=TestAccNetAppVolume_protocolConversion -count=1' TESTTIMEOUT='1200m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolume_protocolConversion -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolume_protocolConversion
=== PAUSE TestAccNetAppVolume_protocolConversion
=== CONT  TestAccNetAppVolume_protocolConversion
--- PASS: TestAccNetAppVolume_protocolConversion (1159.00s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp        1159.041s

pmarques [ ~/go/src/github.com/hashicorp/terraform-provider-azurerm ]$ make acctests SERVICE='netapp' TESTARGS=' -parallel 1 -run=TestAccNetAppVolumeGroupSAPHana_protocolConversion -count=1' TESTTIMEOUT='1200m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupSAPHana_protocolConversion -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupSAPHana_protocolConversion
=== PAUSE TestAccNetAppVolumeGroupSAPHana_protocolConversion
=== CONT  TestAccNetAppVolumeGroupSAPHana_protocolConversion
--- PASS: TestAccNetAppVolumeGroupSAPHana_protocolConversion (1839.64s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp        1839.673s

pmarques [ ~/go/src/github.com/hashicorp/terraform-provider-azurerm ]$ make acctests SERVICE='netapp' TESTARGS=' -parallel 1 -run=TestAccNetAppVolumeGroupOracle_basicAvailabilityZone -count=1' TESTTIMEOUT='1200m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupOracle_basicAvailabilityZone -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupOracle_basicAvailabilityZone
=== PAUSE TestAccNetAppVolumeGroupOracle_basicAvailabilityZone
=== CONT  TestAccNetAppVolumeGroupOracle_basicAvailabilityZone
--- PASS: TestAccNetAppVolumeGroupOracle_basicAvailabilityZone (1114.16s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp        1114.195s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

… NFSv4.1 and example

…protocol conversion example

… update export policy handling

mbfrahry

LGTM

github-actions · 2025-10-26T02:21:46Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

paulomarquesc added 5 commits September 12, 2025 21:54

feat: add support NetApp volume protocol conversion between NFSv3 and…

cf664a3

… NFSv4.1 and example

fix: fixing issues

656e9ef

fix: update default values for resource group and location in NetApp …

579d96b

…protocol conversion example

refactor: update NetApp protocol conversion example and remove outputs

588572d

feat: add protocol conversion validation for NetApp volume groups and…

99eaa5a

… update export policy handling

paulomarquesc requested review from a team, WodansSon and magodo as code owners September 17, 2025 23:56

github-actions bot added enhancement documentation service/netapp size/XL waiting-response labels Sep 17, 2025

fix: fixing linting issues

171dc77

github-actions bot removed the waiting-response label Sep 18, 2025

mbfrahry approved these changes Sep 24, 2025

View reviewed changes

mbfrahry changed the title ~~netapp_volume, netapp_volume_group_oracle, netapp_volume_group_sap_hana: protocol conversion support~~ azurerm_netapp_volume, azurerm_netapp_volume_group_oracle, azurerm_netapp_volume_group_sap_hana - add support for updating protocols Sep 25, 2025

mbfrahry added this to the v4.46.0 milestone Sep 25, 2025

mbfrahry merged commit 80671bd into hashicorp:main Sep 25, 2025
37 checks passed

mbfrahry added a commit that referenced this pull request Sep 25, 2025

Update CHANGELOG.md for #30643

514e8f1

mbfrahry added a commit that referenced this pull request Sep 25, 2025

Update CHANGELOG.md for #30643

f2bd3ac

github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_netapp_volume`, `azurerm_netapp_volume_group_oracle`, `azurerm_netapp_volume_group_sap_hana` - add support for updating `protocols`#30643

`azurerm_netapp_volume`, `azurerm_netapp_volume_group_oracle`, `azurerm_netapp_volume_group_sap_hana` - add support for updating `protocols`#30643
mbfrahry merged 6 commits intohashicorp:mainfrom
paulomarquesc:pmarques/convert-nfsv3-nfsv41-v4

paulomarquesc commented Sep 17, 2025 •

edited

Loading

Uh oh!

mbfrahry left a comment

Uh oh!

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

paulomarquesc commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Testing

Unit Tests

Acceptance tests with imapcted resources

Change Log

Uh oh!

mbfrahry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

paulomarquesc commented Sep 17, 2025 •

edited

Loading