Skip to content

Add .NET 10 support for dotnet_version to linux and windows app service#31007

Merged
sreallymatt merged 4 commits intohashicorp:mainfrom
psyvision:feature/app_service_10
Nov 19, 2025
Merged

Add .NET 10 support for dotnet_version to linux and windows app service#31007
sreallymatt merged 4 commits intohashicorp:mainfrom
psyvision:feature/app_service_10

Conversation

@psyvision
Copy link
Contributor

@psyvision psyvision commented Nov 2, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Add support for .NET 10 dotnet_version for both windows and linux App Service web and function apps.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccLinuxWebApp_withDotNet100 -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccLinuxWebApp_withDotNet100
=== PAUSE TestAccLinuxWebApp_withDotNet100
=== CONT  TestAccLinuxWebApp_withDotNet100
--- PASS: TestAccLinuxWebApp_withDotNet100 (284.74s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    284.781s

TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccWindowsWebApp_withDotNet100 -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccWindowsWebApp_withDotNet100
=== PAUSE TestAccWindowsWebApp_withDotNet100
=== CONT  TestAccWindowsWebApp_withDotNet100
--- PASS: TestAccWindowsWebApp_withDotNet100 (259.12s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    259.163s

TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccLinuxFunctionApp_appStackDotNet10Isolated -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccLinuxFunctionApp_appStackDotNet10Isolated
=== PAUSE TestAccLinuxFunctionApp_appStackDotNet10Isolated
=== CONT  TestAccLinuxFunctionApp_appStackDotNet10Isolated
--- PASS: TestAccLinuxFunctionApp_appStackDotNet10Isolated (309.29s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    309.332s

TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccWindowsFunctionApp_appStackDotNet10Isolated -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccWindowsFunctionApp_appStackDotNet10Isolated
=== PAUSE TestAccWindowsFunctionApp_appStackDotNet10Isolated
=== CONT  TestAccWindowsFunctionApp_appStackDotNet10Isolated
--- PASS: TestAccWindowsFunctionApp_appStackDotNet10Isolated (299.82s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    299.864s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes 30735
Fixes 31141

AI Assistance Disclosure

  • AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@psyvision psyvision changed the title Add .NET 10 support for dotnet_version to both linux and windows web apps Add .NET 10 support for dotnet_version to linux and windows app service Nov 2, 2025
@psyvision psyvision marked this pull request as ready for review November 2, 2025 20:25
@psyvision psyvision requested review from a team, WodansSon and magodo as code owners November 2, 2025 20:25
@pregress
Copy link
Contributor

@WodansSon or @magodo can this be reviewed and released?
dotnet 10 was released yesterday

@ilmax
Copy link
Contributor

ilmax commented Nov 14, 2025

It would be great to get this merged soon. 🙂
I’ve also been wondering about the value of doing this kind of client-side validation in the provider. Why not rely on the underlying API to handle it, or offer an option to disable the validation, instead of requiring a switch to the AzAPI provider to achieve the same result?

I’ve also run into situations where deploying an application that targets a newer .NET version forced me to upgrade the provider unexpectedly, adding extra work that wasn’t planned.

@pregress
Copy link
Contributor

@jackofallops can you have a look?

@@ -179,6 +179,7 @@ ASP.NET V4.8 | v4.0
.NET 7 (STS) | v7.0
Copy link
Contributor

@ossentoo ossentoo Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.NET 7.0 (STS) no longer supported on Azure Web apps:

Image

I would suggest this should be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the route to deprecation is here, v6 is also still in the provider but not available either.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe making some cleanup is not as urgent as adding this new version.

And what would be the impact of removing older versions on running webapps / functions / else ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with hangar18rip. 🎸
Adding versions = feature, removing versions = breaking change.

Copy link
Contributor

@ossentoo ossentoo Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand. I suggest my comment be ignored then. Better that this doesn't become a breaking change

@hangar18rip
Copy link

hi @WodansSon / @magodo. what's the plan for this PR please ?

@VultureJD
Copy link

Why does this always take so long every year? .NET releases are very well-known in advance and Azure has had Day 1 support for the last several years, so why can’t azurerm? This PR alone has been sitting here for over 2 weeks with next to 0 movement. Can it just be approved please?

@pregress
Copy link
Contributor

@sreallymatt maybe you can have a look?

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @psyvision and @sreallymatt - LGTM 👍

@sreallymatt
Copy link
Collaborator

image

@sreallymatt sreallymatt merged commit 2727240 into hashicorp:main Nov 19, 2025
33 checks passed
@github-actions github-actions bot added this to the v4.54.0 milestone Nov 19, 2025
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for .net 10 in azurerm_linux_web_app Function App - Add support for dotnet 10.0 for Windows/Linux

9 participants