azurerm_mysql_flexible_server: 8.4 version support#31099
azurerm_mysql_flexible_server: 8.4 version support#31099sreallymatt merged 4 commits intohashicorp:mainfrom
Conversation
sreallymatt
left a comment
There was a problem hiding this comment.
Thanks @gerrytan, I've left a couple comments inline
| string(servers.ServerVersionFivePointSeven), | ||
| string(servers.ServerVersionEightPointZeroPointTwoOne), | ||
| string(validate.ServerVersionEightPointFour), | ||
| string(validate.ServerVersionNinePointThree), |
There was a problem hiding this comment.
9.3 is not GA, we generally don't add preview features to the azurerm provider except in exceptional circumstances.
There was a problem hiding this comment.
@sreallymatt see the reasons I put on the PR description. The API itself is stable, and I've already added a note in the doc about this.
Including this would benefit customers that want to evaluate 9.3 in their testing environment using azurerm Terraform.
There was a problem hiding this comment.
The API itself may be stable but the functionality isn't as it's still documented as being in a preview state rather than GA?
There was a problem hiding this comment.
Ok I'll remove 9.3 support.
|
Thank you for reviewing @sreallymatt , can you please take a look at this PR again. |
|
@sreallymatt 9.3 version support has been dropped, missing enum spec issue comment has been added and I have triggered another acctest run. Please have another look at this PR 🙏. |
|
Thank you @sreallymatt @mbfrahry 🙏 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
Adds support for version 8.4
and 9.3.9.3 is an innovation release that has only 30 day lifecycle, but it is supported regardless for 2 reasons:1. It will be stable in the future2. Customers can evaluate via Terraform in their testing environmentUpdate 2025-11-19: 9.3 version support has been dropped from this PR. See discussion.
The version enum is not available in the current API spec 2023-12-30, and not even in latest stable 2024-12-30, so I have to resort to add separate constants. A bug has been filed for this: Azure/azure-rest-api-specs#38382.
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
https://hashicorp.teamcity.com/buildConfiguration/TF_AzureRM_AZURERM_SERVICE_PUBLIC_MYSQL/532834
The 4 test failures are pre-existing from main: https://hashicorp.teamcity.com/buildConfiguration/TF_AzureRM_AZURERM_SERVICE_PUBLIC_MYSQL/526380
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_mysql_flexible_server: 8.4 and 9.3versionsupportThis is a (please select all that apply):
Related Issue(s)
Closes #30677
AI Assistance Disclosure
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.