New List Resource: azurerm_resource_group

[sreallymatt]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

• Adds list support to azurerm_resource_group
• Bumps github.com/hashicorp/terraform-plugin-testing to 1.14.0

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

List test result:

--- PASS: TestAccResourceGroup_list_basic (66.79s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

AI Assistance Disclosure

• AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[magodo]

Shall we stick onusing the subscription id that is configured with the provider? So far the provider is meant to work for the specified subscription, though there are a variety of requests/issues around cross subscription, we used to suggest the users to use provider alias instead.

Exposing this subscription_id seems to be an exception of the above single subscription assumption.

[sreallymatt]

For List Resources, standard practice so far has been to expose a subscription_id attribute (where the API has a List By Subscription endpoint). We also have an internal issue on expanding the provider to work properly with multiple subscriptions, however I'm not sure what the priority of that is.

Given @jackofallops implemented the initial List Resources, establishing this pattern, I'm going to have to defer this question to him.

[jackofallops]

Thanks for the question @magodo

Allowing users to list/discover resources in another subscription they have access to is not managing those resources, but rather allowing users the option to find and optionally create import configurations for them.

You are correct that, today, those import configs will need to have a provider alias with the other subscription configured, or another config entirely, to manage the resources in the non-local config. We felt it useful/convenient to allow users this option for the purposes of discovery.

Hope that helps!

[magodo]

Thank you @sreallymatt and @jackofallops for the clarifications! Regarding the usage of the listed resources, per my understanding they are only used for importing and optionally generating the configuration. For this purpose, if a user specify a provider alias A (or leave it empty) in the list block, how will those resources belonging to other subscriptions be used in the final result?

[github-actions]

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.