azurerm_databricks_workspace_root_dbfs_customer_managed_key - fix panics, allow managed hsm, and allow versionless keys

[sreallymatt]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR resolves some bugs and adds additional functionality:

• resolves panics in the event the CMK is removed from the azurerm_databricks_workspace
• fixes the delete timeout (it was using the read timeout value, which is too short in many cases)
• adds support for keys from a managed HSM vault
• adds support for versionless keys

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

2 failures:

basicAltSubscription was ignoring the wrong field during the ImportStep, fixed and reran:

--- PASS: TestAccDatabricksWorkspaceRootDbfsCustomerManagedKey_basicAltSubscription (1127.01s)

basicManagedHSM seems to have failed due to a timing issue regarding the permissions allocated to the SP running Terraform. Transient error, succeeded on rerun:

--- PASS: TestAccDatabricksWorkspaceRootDbfsCustomerManagedKey_basicManagedHSM (3352.33s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #25896
Fixes #27739

AI Assistance Disclosure

• AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[catriona-m]

Thanks @sreallymatt LGTM! Left one comment on your //todo but we don't necessarily have to fix that in this pr.

[catriona-m]

I agree that we should probably remove these checks from the create/update. We don't typically check this in other customer_managed_key resources and there doesn't seem to be any particular reason it was added in this one in the first place?

[sreallymatt]

No particular reason I was able to find, I'll add an issue internally to resolve this TODO

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.