Skip to content

data.azurerm_container_registry - admin_password is now sensitive#31428

Merged
mbfrahry merged 2 commits intohashicorp:mainfrom
WestonReed:patch-1
Jan 13, 2026
Merged

data.azurerm_container_registry - admin_password is now sensitive#31428
mbfrahry merged 2 commits intohashicorp:mainfrom
WestonReed:patch-1

Conversation

@WestonReed
Copy link
Contributor

@WestonReed WestonReed commented Dec 30, 2025

Closes #31427

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Fixes an issue with the admin_password output not being marked sensitive.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • container_registry_data_source - mark admin_password as sensitive

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #31427

AI Assistance Disclosure

  • AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @WestonReed, this change looks good but the formatting is a little off! Can you take a look?

@WestonReed
Copy link
Contributor Author

Hey @WestonReed, this change looks good but the formatting is a little off! Can you take a look?

Sorry about that! Should be fixed now.

@mbfrahry mbfrahry changed the title internal: services: containers: container_registry_data_source: mark admin_password as sensitive data.azurerm_container_registry - admin_password is now sensitive Jan 12, 2026
@mbfrahry mbfrahry self-assigned this Jan 12, 2026
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry merged commit f1aec10 into hashicorp:main Jan 13, 2026
34 checks passed
@github-actions github-actions bot added this to the v4.58.0 milestone Jan 13, 2026
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data Source azurerm_container_registry.admin_password is not marked sensitive

3 participants