Skip to content

azurerm_logic_app_trigger_http_request - fix a bug when import empty trigger#31433

Merged
sreallymatt merged 2 commits intohashicorp:mainfrom
ziyeqf:issue/31072
Jan 30, 2026
Merged

azurerm_logic_app_trigger_http_request - fix a bug when import empty trigger#31433
sreallymatt merged 2 commits intohashicorp:mainfrom
ziyeqf:issue/31072

Conversation

@ziyeqf
Copy link
Collaborator

@ziyeqf ziyeqf commented Jan 5, 2026

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

When the trigger is created via portal the input may be nil, previously it causes import error as #31072

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #31072

AI Assistance Disclosure

  • AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@teowa
Copy link
Collaborator

teowa commented Jan 5, 2026

LGTM!

@gerrytan gerrytan self-requested a review January 12, 2026 04:55
Copy link
Collaborator

@gerrytan gerrytan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ziyeqf , is it possible to add acctest to reproduce the empty trigger import?

Otherwise I have checked the acctest result and the diff and this PR LGTM.

@ziyeqf
Copy link
Collaborator Author

ziyeqf commented Jan 13, 2026

Thank you @ziyeqf , is it possible to add acctest to reproduce the empty trigger import?

Otherwise I have checked the acctest result and the diff and this PR LGTM.

I don't think we can do so since creating a trigger by TF can not produce empty trigger.

@ziyeqf ziyeqf marked this pull request as ready for review January 13, 2026 03:03
@ziyeqf ziyeqf requested review from a team, WodansSon and magodo as code owners January 13, 2026 03:03
Copy link
Collaborator

@gerrytan gerrytan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No prob, this PR LGTM. Approved.

Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ziyeqf - LGTM ✅

image

@sreallymatt sreallymatt merged commit 48e71b8 into hashicorp:main Jan 30, 2026
35 checks passed
@github-actions github-actions bot added this to the v4.59.0 milestone Jan 30, 2026
hqhqhqhqhqhqhqhqhqhqhq pushed a commit to hqhqhqhqhqhqhqhqhqhqhq/terraform-provider-azurerm that referenced this pull request Feb 12, 2026
…y trigger (hashicorp#31433)

[BUG] * `azurerm_logic_app_trigger_http_request` - fix an issue that prevented importing existing resources due to empty trigger inputs
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Importing logic app gives Error: inputs was nil for HTTP Trigger Trigger

4 participants