`azurerm_netapp_volume_group_sap_hana_resource` - add support for `zone`, `encryption_key_source`, `key_vault_private_endpoint_id`, and `network_features` by paulomarquesc · Pull Request #31603 · hashicorp/terraform-provider-azurerm

paulomarquesc · 2026-01-27T22:33:42Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This feature extends the existing HANA API to allow customers to select a availability zone as alternative to PPG as well as Standard Network as alternative to basic networking.

Allow standard network features (network_features)
Allow availability zone (zone)
Allow customer-managed keys (encryption_key_source, key_vault_private_endpoint_id)

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Acceptance Tests for AVG For SAP HANA and Oracle results:

Consolidated Passed Tests
==========================
Generated: Mon Jan 26 2026
This file contains all tests that passed, with only the latest run of each test (no duplicates).

================================================================================
SAP HANA VOLUME GROUP TESTS
================================================================================

Log file: test_run_20260122_001411.log
Running test: TestAccNetAppVolumeGroupSAPHana_crossRegionReplication
Start time: Thu Jan 22 00:14:11 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupSAPHana_crossRegionReplication -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupSAPHana_crossRegionReplication
=== PAUSE TestAccNetAppVolumeGroupSAPHana_crossRegionReplication
=== CONT  TestAccNetAppVolumeGroupSAPHana_crossRegionReplication
--- PASS: TestAccNetAppVolumeGroupSAPHana_crossRegionReplication (2453.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	2453.109s
-----------------------------------------
End time: Thu Jan 22 00:55:42 UTC 2026
Test TestAccNetAppVolumeGroupSAPHana_crossRegionReplication completed successfully.
-----------------------------------------

Log file: test_run_20260122_001411.log
Running test: TestAccNetAppVolumeGroupSAPHana_protocolConversion
Start time: Thu Jan 22 00:55:43 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupSAPHana_protocolConversion -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupSAPHana_protocolConversion
=== PAUSE TestAccNetAppVolumeGroupSAPHana_protocolConversion
=== CONT  TestAccNetAppVolumeGroupSAPHana_protocolConversion
--- PASS: TestAccNetAppVolumeGroupSAPHana_protocolConversion (1811.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1811.590s
-----------------------------------------
End time: Thu Jan 22 01:26:31 UTC 2026
Test TestAccNetAppVolumeGroupSAPHana_protocolConversion completed successfully.
-----------------------------------------

Log file: test_run_20260122_001411.log
Running test: TestAccNetAppVolumeGroupSAPHana_snapshotPolicy
Start time: Thu Jan 22 01:26:31 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupSAPHana_snapshotPolicy -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupSAPHana_snapshotPolicy
=== PAUSE TestAccNetAppVolumeGroupSAPHana_snapshotPolicy
=== RUN   TestAccNetAppVolumeGroupSAPHana_snapshotPolicyUpdate
=== PAUSE TestAccNetAppVolumeGroupSAPHana_snapshotPolicyUpdate
=== CONT  TestAccNetAppVolumeGroupSAPHana_snapshotPolicy
--- PASS: TestAccNetAppVolumeGroupSAPHana_snapshotPolicy (1239.37s)
=== CONT  TestAccNetAppVolumeGroupSAPHana_snapshotPolicyUpdate
--- PASS: TestAccNetAppVolumeGroupSAPHana_snapshotPolicyUpdate (1598.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	2838.217s
-----------------------------------------
End time: Thu Jan 22 02:14:25 UTC 2026
Test TestAccNetAppVolumeGroupSAPHana_snapshotPolicy completed successfully.
-----------------------------------------

Log file: test_run_20260122_001411.log
Running test: TestAccNetAppVolumeGroupSAPHana_snapshotPolicyUpdate
Start time: Thu Jan 22 02:42:53 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupSAPHana_snapshotPolicyUpdate -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupSAPHana_snapshotPolicyUpdate
=== PAUSE TestAccNetAppVolumeGroupSAPHana_snapshotPolicyUpdate
=== CONT  TestAccNetAppVolumeGroupSAPHana_snapshotPolicyUpdate
--- PASS: TestAccNetAppVolumeGroupSAPHana_snapshotPolicyUpdate (1663.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1663.600s
-----------------------------------------
End time: Thu Jan 22 03:11:13 UTC 2026
Test TestAccNetAppVolumeGroupSAPHana_snapshotPolicyUpdate completed successfully.
-----------------------------------------

Log file: test_run_20260126_162128.log
Running test: TestAccNetAppVolumeGroupSAPHanaDataSource_basic (exact match)
Test pattern: TestAccNetAppVolumeGroupSAPHanaDataSource_basic$$
Start time: Mon Jan 26 16:21:28 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -count=1 -run=TestAccNetAppVolumeGroupSAPHanaDataSource_basic$ -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupSAPHanaDataSource_basic
=== PAUSE TestAccNetAppVolumeGroupSAPHanaDataSource_basic
=== CONT  TestAccNetAppVolumeGroupSAPHanaDataSource_basic
--- PASS: TestAccNetAppVolumeGroupSAPHanaDataSource_basic (1210.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1210.457s
-----------------------------------------
End time: Mon Jan 26 16:42:56 UTC 2026
Test TestAccNetAppVolumeGroupSAPHanaDataSource_basic completed successfully.
-----------------------------------------

Log file: test_run_20260126_162128.log
Running test: TestAccNetAppVolumeGroupSAPHana_backupVolumeSpecsNfsv3 (exact match)
Test pattern: TestAccNetAppVolumeGroupSAPHana_backupVolumeSpecsNfsv3$$
Start time: Mon Jan 26 16:42:56 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -count=1 -run=TestAccNetAppVolumeGroupSAPHana_backupVolumeSpecsNfsv3$ -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupSAPHana_backupVolumeSpecsNfsv3
=== PAUSE TestAccNetAppVolumeGroupSAPHana_backupVolumeSpecsNfsv3
=== CONT  TestAccNetAppVolumeGroupSAPHana_backupVolumeSpecsNfsv3
--- PASS: TestAccNetAppVolumeGroupSAPHana_backupVolumeSpecsNfsv3 (1597.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1597.899s
-----------------------------------------
End time: Mon Jan 26 17:10:10 UTC 2026
Test TestAccNetAppVolumeGroupSAPHana_backupVolumeSpecsNfsv3 completed successfully.
-----------------------------------------

Log file: test_run_20260126_162128.log
Running test: TestAccNetAppVolumeGroupSAPHana_basicAvailabilityZone (exact match)
Test pattern: TestAccNetAppVolumeGroupSAPHana_basicAvailabilityZone$$
Start time: Mon Jan 26 17:17:33 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -count=1 -run=TestAccNetAppVolumeGroupSAPHana_basicAvailabilityZone$ -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupSAPHana_basicAvailabilityZone
=== PAUSE TestAccNetAppVolumeGroupSAPHana_basicAvailabilityZone
=== CONT  TestAccNetAppVolumeGroupSAPHana_basicAvailabilityZone
--- PASS: TestAccNetAppVolumeGroupSAPHana_basicAvailabilityZone (1085.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1085.225s
-----------------------------------------
End time: Mon Jan 26 17:36:03 UTC 2026
Test TestAccNetAppVolumeGroupSAPHana_basicAvailabilityZone completed successfully.
-----------------------------------------

Log file: test_run_20260126_162128.log
Running test: TestAccNetAppVolumeGroupSAPHana_volCustomerManagedKeyEncryption (exact match)
Test pattern: TestAccNetAppVolumeGroupSAPHana_volCustomerManagedKeyEncryption$$
Start time: Mon Jan 26 17:36:03 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -count=1 -run=TestAccNetAppVolumeGroupSAPHana_volCustomerManagedKeyEncryption$ -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupSAPHana_volCustomerManagedKeyEncryption
=== PAUSE TestAccNetAppVolumeGroupSAPHana_volCustomerManagedKeyEncryption
=== CONT  TestAccNetAppVolumeGroupSAPHana_volCustomerManagedKeyEncryption
--- PASS: TestAccNetAppVolumeGroupSAPHana_volCustomerManagedKeyEncryption (1319.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1319.050s
-----------------------------------------
End time: Mon Jan 26 17:58:40 UTC 2026
Test TestAccNetAppVolumeGroupSAPHana_volCustomerManagedKeyEncryption completed successfully.
-----------------------------------------

Log file: test_run_20260126_162128.log
Running test: TestAccNetAppVolumeGroupSAPHana_volumeUpdates (exact match)
Test pattern: TestAccNetAppVolumeGroupSAPHana_volumeUpdates$$
Start time: Mon Jan 26 17:58:40 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -count=1 -run=TestAccNetAppVolumeGroupSAPHana_volumeUpdates$ -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupSAPHana_volumeUpdates
=== PAUSE TestAccNetAppVolumeGroupSAPHana_volumeUpdates
=== CONT  TestAccNetAppVolumeGroupSAPHana_volumeUpdates
--- PASS: TestAccNetAppVolumeGroupSAPHana_volumeUpdates (1466.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1466.742s
-----------------------------------------
End time: Mon Jan 26 18:23:44 UTC 2026
Test TestAccNetAppVolumeGroupSAPHana_volumeUpdates completed successfully.
-----------------------------------------

Log file: test_run_20260126_201258.log
Running test: TestAccNetAppVolumeGroupSAPHana_basic (exact match)
Test pattern: TestAccNetAppVolumeGroupSAPHana_basic$$
Start time: Mon Jan 26 20:12:58 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -count=1 -run=TestAccNetAppVolumeGroupSAPHana_basic$ -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupSAPHana_basic
=== PAUSE TestAccNetAppVolumeGroupSAPHana_basic
=== CONT  TestAccNetAppVolumeGroupSAPHana_basic
--- PASS: TestAccNetAppVolumeGroupSAPHana_basic (1175.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1175.829s
-----------------------------------------
End time: Mon Jan 26 20:33:09 UTC 2026
Test TestAccNetAppVolumeGroupSAPHana_basic completed successfully.
-----------------------------------------

================================================================================
ORACLE VOLUME GROUP TESTS
================================================================================

Log file: test_run_20260122_161900.log
Running test: TestAccNetAppVolumeGroupOracleDataSource_basic
Start time: Thu Jan 22 16:19:00 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupOracleDataSource_basic -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupOracleDataSource_basic
=== PAUSE TestAccNetAppVolumeGroupOracleDataSource_basic
=== CONT  TestAccNetAppVolumeGroupOracleDataSource_basic
--- PASS: TestAccNetAppVolumeGroupOracleDataSource_basic (1052.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1052.648s
-----------------------------------------
End time: Thu Jan 22 16:37:22 UTC 2026
Test TestAccNetAppVolumeGroupOracleDataSource_basic completed successfully.
-----------------------------------------

Log file: test_run_20260122_161900.log
Running test: TestAccNetAppVolumeGroupOracle_basicAvailabilityZone
Start time: Thu Jan 22 16:37:22 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupOracle_basicAvailabilityZone -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupOracle_basicAvailabilityZone
=== PAUSE TestAccNetAppVolumeGroupOracle_basicAvailabilityZone
=== CONT  TestAccNetAppVolumeGroupOracle_basicAvailabilityZone
--- PASS: TestAccNetAppVolumeGroupOracle_basicAvailabilityZone (1117.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1117.451s
-----------------------------------------
End time: Thu Jan 22 16:56:37 UTC 2026
Test TestAccNetAppVolumeGroupOracle_basicAvailabilityZone completed successfully.
-----------------------------------------

Log file: test_run_20260123_014941.log
Running test: TestAccNetAppVolumeGroupOracle_basicProximityPlacementGroup (exact match)
Test pattern: TestAccNetAppVolumeGroupOracle_basicProximityPlacementGroup$$
Start time: Fri Jan 23 01:49:41 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -count=1 -run=TestAccNetAppVolumeGroupOracle_basicProximityPlacementGroup$ -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupOracle_basicProximityPlacementGroup
=== PAUSE TestAccNetAppVolumeGroupOracle_basicProximityPlacementGroup
=== CONT  TestAccNetAppVolumeGroupOracle_basicProximityPlacementGroup
--- PASS: TestAccNetAppVolumeGroupOracle_basicProximityPlacementGroup (1158.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1158.823s
-----------------------------------------
End time: Fri Jan 23 02:09:36 UTC 2026
Test TestAccNetAppVolumeGroupOracle_basicProximityPlacementGroup completed successfully.
-----------------------------------------

Log file: test_run_20260123_205545.log
Running test: TestAccNetAppVolumeGroupOracle_crossRegionReplication (exact match)
Test pattern: TestAccNetAppVolumeGroupOracle_crossRegionReplication$$
Start time: Fri Jan 23 20:55:45 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -count=1 -run=TestAccNetAppVolumeGroupOracle_crossRegionReplication$ -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupOracle_crossRegionReplication
=== PAUSE TestAccNetAppVolumeGroupOracle_crossRegionReplication
=== CONT  TestAccNetAppVolumeGroupOracle_crossRegionReplication
--- PASS: TestAccNetAppVolumeGroupOracle_crossRegionReplication (2597.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	2597.496s
-----------------------------------------
End time: Fri Jan 23 21:39:31 UTC 2026
Test TestAccNetAppVolumeGroupOracle_crossRegionReplication completed successfully.
-----------------------------------------

Log file: test_run_20260123_205545.log
Running test: TestAccNetAppVolumeGroupOracle_crossRegionReplicationAZ (exact match)
Test pattern: TestAccNetAppVolumeGroupOracle_crossRegionReplicationAZ$$
Start time: Fri Jan 23 21:39:31 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -count=1 -run=TestAccNetAppVolumeGroupOracle_crossRegionReplicationAZ$ -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupOracle_crossRegionReplicationAZ
=== PAUSE TestAccNetAppVolumeGroupOracle_crossRegionReplicationAZ
=== CONT  TestAccNetAppVolumeGroupOracle_crossRegionReplicationAZ
--- PASS: TestAccNetAppVolumeGroupOracle_crossRegionReplicationAZ (2368.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	2369.005s
-----------------------------------------
End time: Fri Jan 23 22:19:39 UTC 2026
Test TestAccNetAppVolumeGroupOracle_crossRegionReplicationAZ completed successfully.
-----------------------------------------

Log file: test_run_20260122_161900.log
Running test: TestAccNetAppVolumeGroupOracle_crossZoneReplicationAZ
Start time: Thu Jan 22 17:45:39 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupOracle_crossZoneReplicationAZ -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupOracle_crossZoneReplicationAZ
=== PAUSE TestAccNetAppVolumeGroupOracle_crossZoneReplicationAZ
=== CONT  TestAccNetAppVolumeGroupOracle_crossZoneReplicationAZ
--- PASS: TestAccNetAppVolumeGroupOracle_crossZoneReplicationAZ (2629.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	2629.705s
-----------------------------------------
End time: Thu Jan 22 18:30:06 UTC 2026
Test TestAccNetAppVolumeGroupOracle_crossZoneReplicationAZ completed successfully.
-----------------------------------------

Log file: test_run_20260122_161900.log
Running test: TestAccNetAppVolumeGroupOracle_nfsv3
Start time: Thu Jan 22 18:30:06 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupOracle_nfsv3 -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupOracle_nfsv3
=== PAUSE TestAccNetAppVolumeGroupOracle_nfsv3
=== CONT  TestAccNetAppVolumeGroupOracle_nfsv3
--- PASS: TestAccNetAppVolumeGroupOracle_nfsv3 (1058.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1058.188s
-----------------------------------------
End time: Thu Jan 22 18:48:22 UTC 2026
Test TestAccNetAppVolumeGroupOracle_nfsv3 completed successfully.
-----------------------------------------

Log file: test_run_20260122_161900.log
Running test: TestAccNetAppVolumeGroupOracle_protocolConversion
Start time: Thu Jan 22 18:48:22 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupOracle_protocolConversion -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupOracle_protocolConversion
=== PAUSE TestAccNetAppVolumeGroupOracle_protocolConversion
=== CONT  TestAccNetAppVolumeGroupOracle_protocolConversion
--- PASS: TestAccNetAppVolumeGroupOracle_protocolConversion (1647.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1647.158s
-----------------------------------------
End time: Thu Jan 22 19:16:25 UTC 2026
Test TestAccNetAppVolumeGroupOracle_protocolConversion completed successfully.
-----------------------------------------

Log file: test_run_20260122_161900.log
Running test: TestAccNetAppVolumeGroupOracle_snapshotPolicy
Start time: Thu Jan 22 19:16:25 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupOracle_snapshotPolicy -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupOracle_snapshotPolicy
=== PAUSE TestAccNetAppVolumeGroupOracle_snapshotPolicy
=== RUN   TestAccNetAppVolumeGroupOracle_snapshotPolicyUpdate
=== PAUSE TestAccNetAppVolumeGroupOracle_snapshotPolicyUpdate
=== CONT  TestAccNetAppVolumeGroupOracle_snapshotPolicy
--- PASS: TestAccNetAppVolumeGroupOracle_snapshotPolicy (1282.22s)
=== CONT  TestAccNetAppVolumeGroupOracle_snapshotPolicyUpdate
--- PASS: TestAccNetAppVolumeGroupOracle_snapshotPolicyUpdate (1618.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	2900.542s
-----------------------------------------
End time: Thu Jan 22 20:05:24 UTC 2026
Test TestAccNetAppVolumeGroupOracle_snapshotPolicy completed successfully.
-----------------------------------------

Log file: test_run_20260122_161900.log
Running test: TestAccNetAppVolumeGroupOracle_snapshotPolicyUpdate
Start time: Thu Jan 22 20:05:24 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupOracle_snapshotPolicyUpdate -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupOracle_snapshotPolicyUpdate
=== PAUSE TestAccNetAppVolumeGroupOracle_snapshotPolicyUpdate
=== CONT  TestAccNetAppVolumeGroupOracle_snapshotPolicyUpdate
--- PASS: TestAccNetAppVolumeGroupOracle_snapshotPolicyUpdate (1639.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1639.651s
-----------------------------------------
End time: Thu Jan 22 20:33:19 UTC 2026
Test TestAccNetAppVolumeGroupOracle_snapshotPolicyUpdate completed successfully.
-----------------------------------------

Log file: test_run_20260122_161900.log
Running test: TestAccNetAppVolumeGroupOracle_volCustomerManagedKeyEncryption
Start time: Thu Jan 22 20:33:19 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupOracle_volCustomerManagedKeyEncryption -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupOracle_volCustomerManagedKeyEncryption
=== PAUSE TestAccNetAppVolumeGroupOracle_volCustomerManagedKeyEncryption
=== CONT  TestAccNetAppVolumeGroupOracle_volCustomerManagedKeyEncryption
--- PASS: TestAccNetAppVolumeGroupOracle_volCustomerManagedKeyEncryption (1259.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1259.229s
-----------------------------------------
End time: Thu Jan 22 20:54:55 UTC 2026
Test TestAccNetAppVolumeGroupOracle_volCustomerManagedKeyEncryption completed successfully.
-----------------------------------------

Log file: test_run_20260122_161900.log
Running test: TestAccNetAppVolumeGroupOracle_volumeUpdates
Start time: Thu Jan 22 20:54:55 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -run=TestAccNetAppVolumeGroupOracle_volumeUpdates -count=1 -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupOracle_volumeUpdates
=== PAUSE TestAccNetAppVolumeGroupOracle_volumeUpdates
=== CONT  TestAccNetAppVolumeGroupOracle_volumeUpdates
--- PASS: TestAccNetAppVolumeGroupOracle_volumeUpdates (1349.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	1349.311s
-----------------------------------------
End time: Thu Jan 22 21:18:01 UTC 2026
Test TestAccNetAppVolumeGroupOracle_volumeUpdates completed successfully.
-----------------------------------------

Log file: test_run_20260126_233226.log
Running test: TestAccNetAppVolumeGroupSAPHana_crossRegionReplicationAZ
Start time: Mon Jan 26 23:32:26 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -count=1 -run=TestAccNetAppVolumeGroupSAPHana_crossRegionReplicationAZ$ -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupSAPHana_crossRegionReplicationAZ
=== PAUSE TestAccNetAppVolumeGroupSAPHana_crossRegionReplicationAZ
=== CONT  TestAccNetAppVolumeGroupSAPHana_crossRegionReplicationAZ
--- PASS: TestAccNetAppVolumeGroupSAPHana_crossRegionReplicationAZ (2551.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	2551.513s
-----------------------------------------
End time: Tue Jan 27 00:15:33 UTC 2026
Test TestAccNetAppVolumeGroupSAPHana_crossRegionReplicationAZ completed successfully.
-----------------------------------------

Log file: test_run_20260126_220017.log
Running test: TestAccNetAppVolumeGroupSAPHana_crossZoneReplicationAZ
Start time: Mon Jan 26 22:00:17 UTC 2026
-----------------------------------------
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/netapp -parallel 1 -count=1 -run=TestAccNetAppVolumeGroupSAPHana_crossZoneReplicationAZ$ -timeout 1200m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetAppVolumeGroupSAPHana_crossZoneReplicationAZ
=== PAUSE TestAccNetAppVolumeGroupSAPHana_crossZoneReplicationAZ
=== CONT  TestAccNetAppVolumeGroupSAPHana_crossZoneReplicationAZ
--- PASS: TestAccNetAppVolumeGroupSAPHana_crossZoneReplicationAZ (2511.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/netapp	2511.723s
-----------------------------------------
End time: Mon Jan 26 22:42:49 UTC 2026
Test TestAccNetAppVolumeGroupSAPHana_crossZoneReplicationAZ completed successfully.
-----------------------------------------

================================================================================
SUMMARY
================================================================================

Total Passed Tests: 24

SAP HANA Tests (12):
  - TestAccNetAppVolumeGroupSAPHanaDataSource_basic
  - TestAccNetAppVolumeGroupSAPHana_backupVolumeSpecsNfsv3
  - TestAccNetAppVolumeGroupSAPHana_basic
  - TestAccNetAppVolumeGroupSAPHana_basicAvailabilityZone
  - TestAccNetAppVolumeGroupSAPHana_crossRegionReplication
  - TestAccNetAppVolumeGroupSAPHana_crossRegionReplicationAZ
  - TestAccNetAppVolumeGroupSAPHana_crossZoneReplicationAZ
  - TestAccNetAppVolumeGroupSAPHana_protocolConversion
  - TestAccNetAppVolumeGroupSAPHana_snapshotPolicy
  - TestAccNetAppVolumeGroupSAPHana_snapshotPolicyUpdate
  - TestAccNetAppVolumeGroupSAPHana_volCustomerManagedKeyEncryption
  - TestAccNetAppVolumeGroupSAPHana_volumeUpdates

Oracle Tests (12):
  - TestAccNetAppVolumeGroupOracleDataSource_basic
  - TestAccNetAppVolumeGroupOracle_basicAvailabilityZone
  - TestAccNetAppVolumeGroupOracle_basicProximityPlacementGroup
  - TestAccNetAppVolumeGroupOracle_crossRegionReplication
  - TestAccNetAppVolumeGroupOracle_crossRegionReplicationAZ
  - TestAccNetAppVolumeGroupOracle_crossZoneReplicationAZ
  - TestAccNetAppVolumeGroupOracle_nfsv3
  - TestAccNetAppVolumeGroupOracle_protocolConversion
  - TestAccNetAppVolumeGroupOracle_snapshotPolicy
  - TestAccNetAppVolumeGroupOracle_snapshotPolicyUpdate
  - TestAccNetAppVolumeGroupOracle_volCustomerManagedKeyEncryption
  - TestAccNetAppVolumeGroupOracle_volumeUpdates

================================================================================

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_netapp_volume_group_sap_hana_resource - support for standard network, availability zones and customer managed keys,

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

AI Assistance Disclosure

AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

…zone replication

…m NetAppVolumeGroupOracleResource tests

mbfrahry

This looks good but I did want to talk through one of the potential changes you made and how it could impact terraform managing this

mbfrahry · 2026-01-28T22:40:04Z

internal/services/netapp/netapp_volume_group_sap_hana_resource.go

+						Type:         pluginsdk.TypeString,
+						Optional:     true,
+						ForceNew:     true,
+						Computed:     true, // O+C - This is computed/optional since there is a feature coming up that will allow customers to change the encryption key source from portal but not the API. This could cause drift if configuration is not updated


Is ignore_changes the plan here for when the portal gets updated? Unfortunately, once someone has specified this in Terraform, they'll trigger this ForceNew if it gets updated in the protal and won't be able to update their config.

internal/services/netapp/netapp_volume_group_sap_hana_resource.go

mbfrahry

LGTM!

…ne`, `encryption_key_source`, `key_vault_private_endpoint_id`, and `network_features` (hashicorp#31603) [ENHANCEMENT] * `azurerm_netapp_volume_group_sap_hana_resource` - add support for `zone`, `encryption_key_source`, `key_vault_private_endpoint_id`, and `network_features`

github-actions · 2026-03-02T02:41:48Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

paulomarquesc added 2 commits January 22, 2026 22:02

SAP HANA feature updates.

910d886

Update SAP HANA NetApp volume group tests for cross-region and cross-…

505c6b7

…zone replication

paulomarquesc requested review from a team, WodansSon and magodo as code owners January 27, 2026 22:33

github-actions bot added ai-assisted enhancement documentation service/netapp size/XL waiting-response labels Jan 27, 2026

Remove unused templateForAvgCrossRegionReplicationOracle function fro…

f01fc5b

…m NetAppVolumeGroupOracleResource tests

github-actions bot removed the waiting-response label Jan 27, 2026

mbfrahry reviewed Jan 28, 2026

View reviewed changes

github-actions bot added the waiting-response label Jan 28, 2026

mbfrahry changed the title ~~azurerm_netapp_volume_group_sap_hana_resource - New features for parity with AVG For Oracle~~ azurerm_netapp_volume_group_sap_hana_resource - add support for zone, encryption_key_source, key_vault_private_endpoint_id, and network_features Jan 31, 2026

mbfrahry approved these changes Jan 31, 2026

View reviewed changes

mbfrahry merged commit bd23402 into hashicorp:main Jan 31, 2026
38 checks passed

github-actions bot added this to the v4.59.0 milestone Jan 31, 2026

github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_netapp_volume_group_sap_hana_resource` - add support for `zone`, `encryption_key_source`, `key_vault_private_endpoint_id`, and `network_features`#31603

`azurerm_netapp_volume_group_sap_hana_resource` - add support for `zone`, `encryption_key_source`, `key_vault_private_endpoint_id`, and `network_features`#31603
mbfrahry merged 3 commits intohashicorp:mainfrom
paulomarquesc:pmarques/saphana-update

paulomarquesc commented Jan 27, 2026

Uh oh!

mbfrahry left a comment

Uh oh!

mbfrahry Jan 28, 2026

Uh oh!

Uh oh!

mbfrahry left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

paulomarquesc commented Jan 27, 2026

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

AI Assistance Disclosure

Uh oh!

mbfrahry left a comment

Choose a reason for hiding this comment

Uh oh!

mbfrahry Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mbfrahry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants