Skip to content

azurerm_web_application_firewall_policy: Adding 2.2 value as allowed in managed_rules.managed_rule_set.version#31674

Merged
sreallymatt merged 4 commits intohashicorp:mainfrom
AndreasLRo:feature/31666-add-drs2.2
Feb 9, 2026
Merged

azurerm_web_application_firewall_policy: Adding 2.2 value as allowed in managed_rules.managed_rule_set.version#31674
sreallymatt merged 4 commits intohashicorp:mainfrom
AndreasLRo:feature/31666-add-drs2.2

Conversation

@AndreasLRo
Copy link
Contributor

@AndreasLRo AndreasLRo commented Feb 4, 2026

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

  • Adding 2.2 value as allowed in managed_rules.managed_rule_set.version.
  • Adding 2.2 value as allowed in managed_rules.exclusion.version.excluded_rule_set.version.
  • Updated Test to use this version.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Test seems to fail, but it failed the same way BEFORE my changes, unsure why the original test was broken and this PR is not the right place to fix it, I think.

Thanks to @mysteq for running the tests.

~/dev/private/terraform-provider-azurerm feature/31666-add-drs2.2 ❯ make acctests SERVICE='network' TESTARGS='-run=TestAccWebApplicationFirewallPolicy_ManagedRuleSetDRS' TESTTIMEOUT='60m'                   15:42:29
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/network -run=TestAccWebApplicationFirewallPolicy_ManagedRuleSetDRS -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccWebApplicationFirewallPolicy_ManagedRuleSetDRS
=== PAUSE TestAccWebApplicationFirewallPolicy_ManagedRuleSetDRS
=== CONT  TestAccWebApplicationFirewallPolicy_ManagedRuleSetDRS
--- PASS: TestAccWebApplicationFirewallPolicy_ManagedRuleSetDRS (223.40s)
PASS
ok   github.com/hashicorp/terraform-provider-azurerm/internal/services/network 225.309s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Enhancement

Related Issue(s)

Fixes #31666

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@AndreasLRo AndreasLRo marked this pull request as ready for review February 4, 2026 14:17
@AndreasLRo AndreasLRo requested review from a team, WodansSon and magodo as code owners February 4, 2026 14:17
@AndreasLRo AndreasLRo marked this pull request as draft February 4, 2026 14:20
@github-actions github-actions bot added size/L and removed size/XL labels Feb 4, 2026
@AndreasLRo AndreasLRo marked this pull request as ready for review February 4, 2026 14:22
@gerrytan gerrytan self-requested a review February 9, 2026 00:07
Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndreasLRo - LGTM ✅

@sreallymatt sreallymatt merged commit c18a5d5 into hashicorp:main Feb 9, 2026
34 checks passed
@github-actions github-actions bot added this to the v4.60.0 milestone Feb 9, 2026
anurag-hashicorp pushed a commit to anurag-hashicorp/terraform-provider-azurerm that referenced this pull request Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WAF policies fail plan validation when using the DRS 2.2 ruleset

2 participants