azurerm_firewall_policy_rule_collection_group implement list and identity

[mstroob]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_firewall_policy_rule_collection_group implement list and identity

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

AI Assistance Disclosure

• AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[mstroob]

Team City Test Results:

PR Number: 312313
Build Number: 611591

All Tests

Status	Test Name	Duration
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_listByFirewallID	108.32s
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_requiresImport	167.11s
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_completePremium	173.56s
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_resourceIdentity	177.02s
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_complete	181.25s
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_basic	187.00s
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_update	270.64s
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_updatePremium	274.37s

Total Passed: 8
Total Failed: 0
Total Tests: 8

[sreallymatt]

Could you add a proper ID here as an example? Can just copy ID from the parent resource's import spec

Suggested change

	firewall_policy_id = "example"
	firewall_policy_id = "/subscription/.../..."

[sreallymatt]

Suggested change

	### List firewall policy rule collection groups in a firewall firewall policy
	### List Firewall Policy Rule Collection Groups in a Firewall Policy

[mstroob]

Team City Test Results:

PR Number: 31741
Build Number: 613580

All Tests

Status	Test Name	Duration
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_listByFirewallID	118.01s
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_requiresImport	156.18s
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_complete	184.44s
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_basic	187.26s
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_resourceIdentity	189.00s
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_completePremium	195.63s
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_updatePremium	278.84s
✅ PASS	TestAccFirewallPolicyRuleCollectionGroup_update	283.76s

Total Passed: 8
Total Failed: 0
Total Tests: 8

[sreallymatt]

LGTM ✅