ensure actions don't break the graph in modules with no instances

[DanielMSchmidt]

Before we only added the root graph node on each module iteration, but we want the root node to always be present in the sub-graph so we moved this call to just before the return statement.

Fixes #38088

Target Release

1.15.x

Rollback Plan

• If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

• This change is user-facing and I added a changelog entry.
• This change is not user-facing.

[dbanck]

Nice!

One question (not intended for this PR): I see that most of the other node expansion logic uses the forEachModuleInstance helper. Would that make sense in the actions context as well?

[DanielMSchmidt]

@dbanck Yeah I think that could make sense, I believe I just copied, I mean was inspired by parts of the code base that didn't use the helper yet. Normally I would be in favor of making that small adjustment but @mildwonkey is currently working on rewriting part of the actions scheduling logic and I don't want refactoring changes to make their life harder so maybe it's sth to keep in mind for after that effort concludes 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.