UI: Fix generic v2 secret engine links (#27019)

* Update generic upgrade test to reflect user behavior

* Fix backend link for generic v2

* Add redirect for generic v2

* more test coverage

* Add changelog

Author: hashishaw

changelog/27019.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+ui: Fix link to v2 generic secrets engine from secrets list page.
+```

ui/app/models/secret-engine.js

@@ -148,6 +148,10 @@ export default class SecretEngineModel extends Model {
       const { engineRoute } = allEngines().findBy('type', this.engineType);
       return `vault.cluster.secrets.backend.${engineRoute}`;
     }
+    if (this.isV2KV) {
+      // if it's KV v2 but not registered as an addon, it's type generic
+      return 'vault.cluster.secrets.backend.kv.list';
+    }
     return `vault.cluster.secrets.backend.list-root`;
   }
 

ui/app/routes/vault/cluster/secrets/backend/list.js

@@ -82,6 +82,9 @@ export default Route.extend({
         return this.router.transitionTo('vault.cluster.secrets.backend.kv.list-directory', backend, secret);
       }
       return this.router.transitionTo(`vault.cluster.secrets.backend.${engineRoute}`, backend);
+    } else if (secretEngine.isV2KV) {
+      // if it's KV v2 but not registered as an addon, it's type generic
+      return this.router.transitionTo('vault.cluster.secrets.backend.kv.list', backend);
     }
     const modelType = this.getModelType(backend, tab);
     return this.pathHelp.getNewModel(modelType, backend).then(() => {

ui/tests/acceptance/secrets/backend/generic/secret-test.js

@@ -3,7 +3,8 @@
  * SPDX-License-Identifier: BUSL-1.1
  */
 
-import { currentRouteName, visit } from '@ember/test-helpers';
+import { click, currentRouteName, settled, visit } from '@ember/test-helpers';
+import { selectChoose } from 'ember-power-select/test-support';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';
 import { v4 as uuidv4 } from 'uuid';
@@ -19,6 +20,7 @@ import { PAGE } from 'vault/tests/helpers/kv/kv-selectors';
 import { create } from 'ember-cli-page-object';
 
 import apiStub from 'vault/tests/helpers/noop-all-api-requests';
+import { deleteEngineCmd, runCmd } from 'vault/tests/helpers/commands';
 
 const cli = create(consolePanel);
 
@@ -65,7 +67,15 @@ module('Acceptance | secrets/generic/create', function (hooks) {
       // upgrade to version 2 generic mount
       `write sys/mounts/${path}/tune options=version=2`,
     ]);
-    await visit(`/vault/secrets/${path}/kv/list`);
+    await visit('/vault/secrets');
+    await selectChoose('[data-test-component="search-select"]#filter-by-engine-name', path);
+    await settled();
+    await click(`[data-test-secrets-backend-link="${path}"]`);
+    assert.strictEqual(
+      currentRouteName(),
+      'vault.cluster.secrets.backend.kv.list',
+      'navigates to the KV engine list page'
+    );
 
     assert
       .dom(PAGE.list.item('foo'))
@@ -78,5 +88,15 @@ module('Acceptance | secrets/generic/create', function (hooks) {
       assert.dom(PAGE.list.item(secret.path)).exists('lists both records');
     });
     assert.dom(PAGE.list.item()).exists({ count: 2 }, 'lists only the two secrets');
+
+    await visit(`/vault/secrets/${path}/list`);
+    assert.strictEqual(
+      currentRouteName(),
+      'vault.cluster.secrets.backend.kv.list',
+      'redirects to the KV engine list page from generic list'
+    );
+
+    // Clean up
+    await runCmd(deleteEngineCmd(path));
   });
 });