Skip to content

fix: Busy responses no longer create Unity Console errors#1168

Merged
hatayama merged 1 commit into
v3-betafrom
feature/hatayama/remove-busy-console-log
May 19, 2026
Merged

fix: Busy responses no longer create Unity Console errors#1168
hatayama merged 1 commit into
v3-betafrom
feature/hatayama/remove-busy-console-log

Conversation

@hatayama
Copy link
Copy Markdown
Owner

Summary

  • Expected busy responses now return through the command result without adding Unity Console errors.
  • Existing JSON-RPC server_busy payloads remain unchanged so CLI clients can keep treating them as retryable.

User Impact

  • When another command arrives while Unity is already running a command, users still receive the busy response.
  • The Unity Console no longer shows an error for this expected single-flight rejection, so real Editor errors are easier to notice.

Changes

  • Skip Unity Console error logging for UnityCliLoopToolBusyException in the JSON-RPC request path.
  • Update busy-response coverage to assert the server_busy payload and no unexpected Console log output.

Verification

  • Packages/src/Cli~/dist/darwin-arm64/uloop compile --project-path /Users/a12115/ghq/hatayama/unity-cli-loop
  • Packages/src/Cli~/dist/darwin-arm64/uloop run-tests --test-mode EditMode --filter-type regex --filter-value JsonRpcProcessorCliVersionGateTests --project-path /Users/a12115/ghq/hatayama/unity-cli-loop
  • Packages/src/Cli~/dist/darwin-arm64/uloop get-logs --log-type Error --max-count 10 --project-path /Users/a12115/ghq/hatayama/unity-cli-loop
  • ~/.codex/skills/codex-review/scripts/codex-review v3-beta

Busy tool requests are protocol-level retry signals, not Editor-side failures. Keep the server_busy JSON response while avoiding noisy Unity Console errors for expected single-flight rejections.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

Warning

Rate limit exceeded

@hatayama has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 43 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 46f4b109-390e-496b-aa07-27ee64c82842

📥 Commits

Reviewing files that changed from the base of the PR and between 6db2446 and 214d589.

📒 Files selected for processing (2)
  • Assets/Tests/Editor/JsonRpcProcessorCliVersionGateTests.cs
  • Packages/src/Editor/Infrastructure/Api/JsonRpcProcessor.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/hatayama/remove-busy-console-log

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@hatayama hatayama merged commit be7aa80 into v3-beta May 19, 2026
8 checks passed
@hatayama hatayama deleted the feature/hatayama/remove-busy-console-log branch May 19, 2026 01:45
@github-actions github-actions Bot mentioned this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant