Skip to content

fix: require skills directories for auto-install detection#912

Merged
hatayama merged 2 commits into
mainfrom
feature/hatayama/fix-skill-auto-install-detection
Apr 9, 2026
Merged

fix: require skills directories for auto-install detection#912
hatayama merged 2 commits into
mainfrom
feature/hatayama/fix-skill-auto-install-detection

Conversation

@hatayama
Copy link
Copy Markdown
Owner

@hatayama hatayama commented Apr 9, 2026

Summary

  • require an existing skills directory before treating .claude, .agents, .cursor, or .agent as auto-install targets
  • keep the installed-state check based on actual uLoop skill directories instead of parent folder presence alone
  • add editor tests for the parent-only case and the empty skills-directory case, and update the setup UI copy to match the new rule

Summary by cubic

Require an existing skills directory for auto-install detection of .claude, .agents, .cursor, and .agent to prevent false positives and unwanted folder creation. The setup wizard still detects tool roots without skills so first-time installs remain available.

  • Bug Fixes
    • Auto-install: detect targets only when <tool>/skills exists; skip parent-only roots.
    • Setup: keep root-directory detection and messaging; offer first-time installs when only the parent exists.
    • Determine installed state via SKILL.md inside uLoop skill folders.
    • Editor tests use temporary project roots; cover parent-only and empty skills cases.

Written for commit ba16bee. Summary will update on new commits.

Require an existing skills directory before treating an AI tool
configuration as an install target so toggling tools no longer
creates skill folders from parent directories alone.

Add editor tests that cover both the parent-only case and the
empty skills-directory case, and update the setup UI message to
match the stricter detection rule.
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 9, 2026

Warning

Rate limit exceeded

@hatayama has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 12 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 2 minutes and 12 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4d3b038a-c3c1-486a-b94c-3eff76e12a64

📥 Commits

Reviewing files that changed from the base of the PR and between ffa3863 and ba16bee.

📒 Files selected for processing (2)
  • Assets/Tests/Editor/ToolSkillSynchronizerTests.cs
  • Packages/src/Editor/Config/ToolSkillSynchronizer.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/hatayama/fix-skill-auto-install-detection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Limit stricter skills-directory checks to implicit auto-install flows so explicit setup can still offer first-time installs for existing tool roots.

Move ToolSkillSynchronizer target detection behind reusable helpers, keep the setup wizard messaging aligned with root-directory detection, and rewrite the editor tests to use temporary project roots instead of environment-dependent assumptions.
@hatayama hatayama merged commit 8832050 into main Apr 9, 2026
10 checks passed
@hatayama hatayama deleted the feature/hatayama/fix-skill-auto-install-detection branch April 9, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant