Skip to content

fix: CLI lint now gets past existing prettier formatting issues#967

Merged
hatayama merged 1 commit into
mainfrom
feature/hatayama/fix-existing-lint-errors
Apr 21, 2026
Merged

fix: CLI lint now gets past existing prettier formatting issues#967
hatayama merged 1 commit into
mainfrom
feature/hatayama/fix-existing-lint-errors

Conversation

@hatayama
Copy link
Copy Markdown
Owner

Summary

  • Remove the remaining CLI prettier formatting errors that were already present on main.
  • Let npm run lint complete with warnings only instead of failing on formatting noise.

User Impact

  • Before this change, contributors could hit lint failures even when they had not introduced any new behavior changes, because a few existing CLI files were still misformatted.
  • After this change, the CLI lint step no longer stops on those old prettier violations, which makes routine verification clearer and less noisy.

Changes

  • Reformat the remaining offending CLI test and implementation files to match the repository's prettier rules.
  • Keep the patch limited to whitespace, wrapping, and blank-line cleanup without changing runtime behavior.

Verification

  • npm run lint
  • npm run build

Format the remaining CLI files that were already failing prettier-based
lint checks on main so `npm run lint` no longer reports formatting errors.
Keep the change limited to line wrapping and blank-line cleanup without
changing runtime behavior.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

Warning

Rate limit exceeded

@hatayama has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 41 minutes and 27 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 41 minutes and 27 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 35ea1d86-6284-42a2-beab-401460f1629d

📥 Commits

Reviewing files that changed from the base of the PR and between 1ea7733 and 0e67b72.

📒 Files selected for processing (4)
  • Packages/src/Cli~/src/__tests__/cli-e2e.test.ts
  • Packages/src/Cli~/src/__tests__/launch-readiness.test.ts
  • Packages/src/Cli~/src/__tests__/skills-manager.test.ts
  • Packages/src/Cli~/src/skills/skills-manager.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/hatayama/fix-existing-lint-errors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@hatayama hatayama merged commit b02b05d into main Apr 21, 2026
4 checks passed
@hatayama hatayama deleted the feature/hatayama/fix-existing-lint-errors branch April 21, 2026 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant