Enhanced selenium tests + bugfixes (#101)

* next build

* Production mode webapp builds

* Enhaned selenium tests, fixed registration

* Test improvements

* made tests work maybe

* increased sleep

* dumb

* wow

* increase sleeps

Author: horahoradev

.github/workflows/test.yml

@@ -14,7 +14,7 @@ jobs:
         run: echo "nginx" | ./up.sh
         if: always()
       - name: Run Selenium tests
-        run: cd selenium && sleep 30 && sudo docker run --net horahora_default $(docker build -q .)
+        run: cd selenium && sleep 90 && sudo docker run --net horahora_default $(docker build -q .)
         if: always()
       - name: Build the stack localhost
         run: echo "localhost" | ./up.sh

front_api/routes/routes.go

@@ -158,6 +158,7 @@ func setCookie(c echo.Context, jwt string) error {
 
 	cookie.SameSite = http.SameSiteStrictMode
 	//cookie.Secure = true // set this later
+	cookie.HttpOnly = false
 
 	c.SetCookie(cookie)
 

selenium/test.py

@@ -4,35 +4,61 @@
 import time
 
 if __name__ == "__main__":
-    chrome_options = webdriver.ChromeOptions()
+    chrome_options = Options()
     chrome_options.add_argument('--no-sandbox')
     chrome_options.add_argument('--window-size=1920,1080')
     chrome_options.add_argument('--headless')
     chrome_options.add_argument('--disable-gpu')
-    driver = webdriver.Chrome(chrome_options=chrome_options)
+
+    driver = webdriver.Chrome(options=chrome_options)
 
     driver.get("http://nginx/authentication/login")
 
-    time.sleep(5)
+    time.sleep(3)
     assert driver.title == "Log in"
 
-    time.sleep(5)
+    time.sleep(3)
 
     username_box = driver.find_element(by=By.ID, value="auth-login-name")
     password_box = driver.find_element(by=By.ID, value="auth-login-password")
     submit_button = driver.find_element(by=By.ID, value="auth-login")
     username_box.send_keys("admin")
     password_box.send_keys("admin")
     submit_button.submit()
-    time.sleep(5)
-    print(driver.get_cookies())
-
-    time.sleep(5)
-    print(driver.current_url)
-    print(driver.get_cookies())
+    time.sleep(3)
 
     assert driver.current_url == "http://nginx/"
     assert driver.title == "Videos"
 
+    driver.get('http://nginx/account/archives')
+    time.sleep(3)
+    assert driver.title == "View and manage your archives"
+    video_box = driver.find_element(by=By.ID, value="new-video-url")
+    video_form = driver.find_element(by=By.ID, value="new-video")
+    video_box.send_keys("https://www.youtube.com/watch?v=GWAtnzcbfFQ")
+    video_form.submit()
+
+    time.sleep(3)
+    dl_card = driver.find_element(by=By.ID, value="download-request-1")
+    assert dl_card is not None
+
+    # Search for author
+    for i in range(1, 80):
+        try:
+            driver.get('http://nginx/search?search=%E3%82%82%E3%81%A1%E3%81%86%E3%81%A4%E3%81%AD&category=upload_date&order=desc')
+            time.sleep(5) # why do we need...
+            video_href = driver.find_element(by=By.ID, value="/videos/1")
+            if video_href is None:
+                print("Failed to find video 1 on page, attempt " + str(i))
+                continue
+            video_href.click()
+            break
+        except:
+            print("Failed to find video 1 on page, attempt " + str(i))
+
+    time.sleep(3)
+    assert driver.current_url == "http://nginx/videos/1"
+    assert driver.title == 'Video "おくすり飲んで寝よう / 初音ミク - もちうつね" (1) by "もちうつね" (1)'
+
     driver.quit()
     print("wow we did it")

user_service/migrations/V1___users_table.sql

@@ -5,4 +5,4 @@ CREATE TABLE users (
     pass_hash varchar(255),
     foreign_user_ID varchar(255),
     foreign_website varchar(255) -- Again, could use enum... lazy schema design...
-);
+);

user_service/protocol/userservice.pb.go

@@ -96,7 +96,7 @@ message validateJWTResponse {
 message RegisterRequest {
     string email = 1 [(validate.rules).string.email = true];
     string username = 2 [(validate.rules).string = {
-        pattern:   "^[^[0-9]A-Za-z]+( [^[0-9]A-Za-z]+)*$",
+        pattern:   "^[a-zA-Z0-9]+$",
         max_bytes: 10,
      }];
     string password = 3;

user_service/protocol/userservice.pb.validate.go

@@ -35,7 +35,7 @@ function Component({ post, headingLevel, ...blockProps }: IPostVideoCardProps) {
   return (
     <Card {...blockProps}>
       <CardHeader>
-        <a href={`/videos/${VideoID}`}>
+        <a id={`/videos/${VideoID}`} href={`/videos/${VideoID}`}>
           <Heading level={headingLevel}>{Title}</Heading>
         </a>
       </CardHeader>

user_service/protocol/userservice.proto

@@ -58,7 +58,7 @@ function AuditsPage() {
             }}
           />
           <CardList>
-            {pageData.Events.map((audit) => (
+            {pageData.Events != null && pageData.Events.map((audit) => (
               <AuditCard key={audit.ID} audit={audit} />
             ))}
           </CardList>