Fix resume_download future warning#31007
Merged
Merged
Conversation
Contributor
Author
|
@ArthurZucker I added a regression test in 6921a7f. It is not related to local_files_only or snapshot_download problems, just a FutureWarning raised when |
Contributor
Author
|
(feel free to merge whenever it's approved/CI is happy) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
May 24, 2024
This was referenced Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #31002 and follow-up #30618.
Looks like I forgot a
resume_downloadin #30618. This PR fixes it to avoid a FutureWarning for which the user can't do much.cc @albertvillanova
Note: this is "simply" as warning but should not trigger any errors. It triggers one in datasets' CI but that's only because of pytest settings.