Skip to content

Should fix, testing#36465

Closed
muellerzr wants to merge 2 commits into
mainfrom
muellerzr-fixup-warning
Closed

Should fix, testing#36465
muellerzr wants to merge 2 commits into
mainfrom
muellerzr-fixup-warning

Conversation

@muellerzr
Copy link
Copy Markdown
Contributor

What does this PR do?

#36463 did not account for the fact that when the shapes mismatch, we just report that we're initing with new weights and continue forward. This PR keeps our old behavior, with the old warnings that were thrown.

Fixes broken main

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qubvel @ArthurZucker

@github-actions github-actions Bot marked this pull request as draft February 27, 2025 21:47
@github-actions
Copy link
Copy Markdown
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@muellerzr muellerzr closed this Feb 27, 2025
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants