Skip to content
This repository was archived by the owner on Oct 2, 2023. It is now read-only.

Commit f9f09f5

Browse files
authored
Merge pull request #54 from Sbrenthughes/openSourceCardFix
Adds missing violation type
2 parents 620157b + 0b9e18a commit f9f09f5

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

exec-ui/src/app/modules/metrics/modules/metrics/open-source-violations/strategies/open-source-violations-graph-strategy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export class OpenSourceViolationsGraphStrategy extends GraphStrategyBase {
2626
}
2727

2828
protected count(seriesElement: MetricTimeSeriesElement): number {
29-
const validSet = new Set(['High', 'Medium', 'Low']);
29+
const validSet = new Set(['Critical', 'High', 'Medium', 'Low']);
3030
return seriesElement.counts
3131
.reduce((sum, item) => validSet.has(item.label['severity']) ? sum + item.value : sum, 0);
3232
}

exec-ui/src/app/modules/metrics/modules/metrics/open-source-violations/strategies/open-source-violations-preview-strategy.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,11 @@ export class OpenSourceViolationsPreviewStrategy extends PreviewStrategyBase {
4141
return runningSums.set(count.label['severity'], newCount);
4242
}, new Map());
4343

44-
if (sums.get('High')) {
44+
if (sums.get('Critical')) {
45+
return [{name: 'Critical', value: sums.get('Critical').toLocaleString()}];
46+
}
47+
48+
if (sums.get('High')) {
4549
return [{name: 'High', value: sums.get('High').toLocaleString()}];
4650
}
4751

exec-ui/src/app/modules/metrics/modules/metrics/open-source-violations/strategies/open-source-violations-primary-metric-strategy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {OpenSourceViolationsConfiguration} from '../open-source-violations.confi
77
@Injectable()
88
export class OpenSourceViolationsPrimaryMetricStrategy extends PrimaryMetricStrategyBase {
99
parse(counts: Count[]): MetricValueModel {
10-
const validSet = new Set(['High', 'Medium', 'Low']);
10+
const validSet = new Set(['Critical', 'High', 'Medium', 'Low']);
1111

1212
return {
1313
name: OpenSourceViolationsConfiguration.buildingBlockLabel,

exec-ui/src/app/modules/metrics/modules/metrics/open-source-violations/strategies/open-source-violations-segmentation-strategy.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,10 @@ export class OpenSourceViolationsSegmentationStrategy implements Strategy<Metric
1212
];
1313

1414
const rows = [
15-
{name: 'High', order: 1},
16-
{name: 'Medium', order: 2},
17-
{name: 'Low', order: 3}
15+
{name: 'Critical', order: 1},
16+
{name: 'High', order: 2},
17+
{name: 'Medium', order: 3},
18+
{name: 'Low', order: 4}
1819
];
1920

2021
return {

0 commit comments

Comments
 (0)