From 1177ba5cc18fd730da9761ed3dc721e00f8235fc Mon Sep 17 00:00:00 2001 From: birjuvachhani Date: Wed, 17 Jul 2024 16:47:20 +0530 Subject: [PATCH 1/3] :bug: fix #27 --- .../lib/src/transformable_box.dart | 19 +++++++++++++------ packages/flutter_box_transform/pubspec.yaml | 3 ++- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/packages/flutter_box_transform/lib/src/transformable_box.dart b/packages/flutter_box_transform/lib/src/transformable_box.dart index e64fbda..bf309a1 100644 --- a/packages/flutter_box_transform/lib/src/transformable_box.dart +++ b/packages/flutter_box_transform/lib/src/transformable_box.dart @@ -378,33 +378,40 @@ class _TransformableBoxState extends State { bool shouldRecalculatePosition = false; bool shouldRecalculateSize = false; - if (oldWidget.rect != widget.rect) { + if (oldWidget.rect != widget.rect || widget.rect != controller.rect) { controller.setRect(widget.rect, notify: false); + shouldRecalculatePosition = true; + shouldRecalculateSize = true; } - if (oldWidget.flip != widget.flip) { + if (oldWidget.flip != widget.flip || widget.flip != controller.flip) { controller.setFlip(widget.flip, notify: false); } - if (oldWidget.resizeModeResolver != widget.resizeModeResolver) { + if (oldWidget.resizeModeResolver != widget.resizeModeResolver || + widget.resizeModeResolver != controller.resizeModeResolver) { controller.setResizeModeResolver( widget.resizeModeResolver, notify: false, ); } - if (oldWidget.clampingRect != widget.clampingRect) { + if (oldWidget.clampingRect != widget.clampingRect || + widget.clampingRect != controller.clampingRect) { controller.setClampingRect(widget.clampingRect, notify: false); shouldRecalculatePosition = true; } - if (oldWidget.constraints != widget.constraints) { + if (oldWidget.constraints != widget.constraints || + widget.constraints != controller.constraints) { controller.setConstraints(widget.constraints, notify: false); shouldRecalculateSize = true; } if (oldWidget.allowFlippingWhileResizing != - widget.allowFlippingWhileResizing) { + widget.allowFlippingWhileResizing || + widget.allowFlippingWhileResizing != + controller.allowFlippingWhileResizing) { controller.setAllowFlippingWhileResizing( widget.allowFlippingWhileResizing, notify: false, diff --git a/packages/flutter_box_transform/pubspec.yaml b/packages/flutter_box_transform/pubspec.yaml index 4a8f151..556d16b 100644 --- a/packages/flutter_box_transform/pubspec.yaml +++ b/packages/flutter_box_transform/pubspec.yaml @@ -15,7 +15,8 @@ environment: dependencies: flutter: sdk: flutter - box_transform: ^0.4.4 + box_transform: + path: ../box_transform vector_math: ^2.1.4 dev_dependencies: From 2aa9c6f52db8061a0eaa2729db2d1bbeec1c054f Mon Sep 17 00:00:00 2001 From: birjuvachhani Date: Sat, 14 Sep 2024 10:41:48 +0530 Subject: [PATCH 2/3] Fix lint warnings --- .../flutter_box_transform/playground/lib/test_recorder.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/flutter_box_transform/playground/lib/test_recorder.dart b/packages/flutter_box_transform/playground/lib/test_recorder.dart index 242a002..d8c0f76 100644 --- a/packages/flutter_box_transform/playground/lib/test_recorder.dart +++ b/packages/flutter_box_transform/playground/lib/test_recorder.dart @@ -513,7 +513,7 @@ class _SingleInputDialogState extends State { validator: widget.validator, ), const SizedBox(height: 20), - ButtonBar( + OverflowBar( children: [ TextButton( onPressed: () => Navigator.pop(context), @@ -593,7 +593,7 @@ class _ExportDialogState extends State { onChanged: (value) => setState(() => roundValues = value ?? false), ), - ButtonBar( + OverflowBar( children: [ TextButton( onPressed: () => Navigator.pop(context), From f302499314bfee155607d4cc06d162f2448b9fa5 Mon Sep 17 00:00:00 2001 From: birjuvachhani Date: Sat, 14 Sep 2024 10:49:02 +0530 Subject: [PATCH 3/3] Upgrade dependencies --- packages/box_transform/pubspec.yaml | 2 +- packages/flutter_box_transform/pubspec.yaml | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/box_transform/pubspec.yaml b/packages/box_transform/pubspec.yaml index bdb3b72..9334b8d 100644 --- a/packages/box_transform/pubspec.yaml +++ b/packages/box_transform/pubspec.yaml @@ -17,7 +17,7 @@ dependencies: dev_dependencies: lints: ^4.0.0 test: ^1.25.8 - coverage: ^1.8.0 + coverage: ^1.9.2 topics: - rectangle diff --git a/packages/flutter_box_transform/pubspec.yaml b/packages/flutter_box_transform/pubspec.yaml index 556d16b..4a8f151 100644 --- a/packages/flutter_box_transform/pubspec.yaml +++ b/packages/flutter_box_transform/pubspec.yaml @@ -15,8 +15,7 @@ environment: dependencies: flutter: sdk: flutter - box_transform: - path: ../box_transform + box_transform: ^0.4.4 vector_math: ^2.1.4 dev_dependencies: