refactor: migrate Js.Math to Math across src/ (33 files, 118 occurrences)

Replace deprecated Js.Math API with modern Math equivalents:
- Js.Math.floor_float -> Math.floor
- Js.Math.sqrt/sin/cos/atan2 -> Math.*
- Js.Math.max_float/min_float -> Math.max/min
- Js.Math._PI -> Math.Constants.pi
- Js.Math.random -> Math.random
- Js.Math.abs_float -> Math.abs

Part of #28.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: hyperpolymath

src/app/GameLoop.res

@@ -677,7 +677,7 @@ let update = (
   // Countdown the startup grace period
   let inGracePeriod = state.gracePeriodSec > 0.0
   if inGracePeriod {
-    state.gracePeriodSec = Js.Math.max_float(0.0, state.gracePeriodSec -. dt)
+    state.gracePeriodSec = Math.max(0.0, state.gracePeriodSec -. dt)
   }
 
   let alertLevel = DetectionSystem.getAlertInt(state.detection)
@@ -786,7 +786,7 @@ let update = (
           )
 
           // DistractionExpired has weight 0  apply the per-type suspicion directly
-          state.detection.alertScore = Js.Math.min_float(
+          state.detection.alertScore = Math.min(
             120.0,
             state.detection.alertScore +. d.spec.suspicionOnExpiry,
           )

src/app/combat/PlayerHP.res

@@ -49,7 +49,7 @@ let isAlive = (hp: t): bool => hp.current > 0.0
 // Take damage from a source position. No-op if invincible.
 let takeDamage = (hp: t, ~amount: float, ~fromX: float, ~playerX: float): unit => {
   if !isInvincible(hp) {
-    hp.current = Js.Math.max_float(0.0, hp.current -. amount)
+    hp.current = Math.max(0.0, hp.current -. amount)
     hp.invincibleTimer = Knockback.iFrames
 
     // Knockback direction: push player away from source
@@ -69,12 +69,12 @@ let takeDamage = (hp: t, ~amount: float, ~fromX: float, ~playerX: float): unit =
 let update = (hp: t, ~dt: float): (float, float) => {
   // Decay invincibility
   if hp.invincibleTimer > 0.0 {
-    hp.invincibleTimer = Js.Math.max_float(0.0, hp.invincibleTimer -. dt)
+    hp.invincibleTimer = Math.max(0.0, hp.invincibleTimer -. dt)
   }
 
   // Decay knockback
   if hp.knockbackTimer > 0.0 {
-    hp.knockbackTimer = Js.Math.max_float(0.0, hp.knockbackTimer -. dt)
+    hp.knockbackTimer = Math.max(0.0, hp.knockbackTimer -. dt)
     let vel = (hp.knockbackVelX, hp.knockbackVelY)
     if hp.knockbackTimer <= 0.0 {
       hp.knockbackVelX = 0.0

src/app/companions/Moletaire.res

@@ -758,7 +758,7 @@ let update = (mole: t, ~dt: float): option<moleEvent> => {
 
   // Hunger increases over time
   if mole.alive {
-    mole.hunger = Js.Math.min_float(1.0, mole.hunger +. Tuning.hungerRate *. dt)
+    mole.hunger = Math.min(1.0, mole.hunger +. Tuning.hungerRate *. dt)
 
     // When hungry, periodically resist player control
     if mole.hunger > Tuning.hungerThreshold {

src/app/devices/NetworkTransfer.res

@@ -89,7 +89,7 @@ let updateTransfers = (deltaSeconds: float): unit => {
     switch t.status {
     | Active => {
         let bytesThisFrame = t.bandwidthMBps *. 1_000_000.0 *. deltaSeconds
-        t.transferredBytes = Js.Math.min_float(t.transferredBytes +. bytesThisFrame, t.totalBytes)
+        t.transferredBytes = Math.min(t.transferredBytes +. bytesThisFrame, t.totalBytes)
 
         // Accumulate router traffic (source = upload, dest = download)
         let currentUp = Dict.get(routerUpload, t.sourceIp)->Belt.Option.getWithDefault(0.0)

src/app/enemies/DetectionSystem.res

@@ -134,7 +134,7 @@ let reportDetection = (system: t, ~source: detectionSource, ~gameTime: float): u
       sourceWeight(source)
     }
 
-    system.alertScore = Js.Math.min_float(120.0, system.alertScore +. weight)
+    system.alertScore = Math.min(120.0, system.alertScore +. weight)
     system.totalDetections = system.totalDetections + 1
 
     let event = {source, timestamp: gameTime, weight}
@@ -153,7 +153,7 @@ let update = (system: t, ~dt: float): unit => {
   // Natural decay  security relaxes over time if nothing happens
   if system.alertScore > 0.0 {
     let decay = system.decayRate *. dt
-    system.alertScore = Js.Math.max_float(0.0, system.alertScore -. decay)
+    system.alertScore = Math.max(0.0, system.alertScore -. decay)
   }
 }
 

src/app/enemies/Distraction.res

@@ -257,7 +257,7 @@ type distractionEvent =
 let update = (pbx: pbxState, ~dt: float): array<distractionEvent> => {
   // Tick cooldown
   if pbx.cooldownSec > 0.0 {
-    pbx.cooldownSec = Js.Math.max_float(0.0, pbx.cooldownSec -. dt)
+    pbx.cooldownSec = Math.max(0.0, pbx.cooldownSec -. dt)
   }
 
   // Tick active distractions, collect events

src/app/enemies/Drone.res

@@ -175,7 +175,7 @@ let detectPlayer = (
     let dx = playerX -. drone.x
     // Y difference between drone altitude and player on ground
     let dy = playerY -. drone.groundY
-    let groundDist = Js.Math.sqrt(dx *. dx +. dy *. dy)
+    let groundDist = Math.sqrt(dx *. dx +. dy *. dy)
 
     let effectiveRadius = if playerCrouching {
       drone.detectionRadius *. 0.6 // Harder to spot crouching from above
@@ -247,7 +247,7 @@ let updateState = (
   } else if (
     drone.state != Charging &&
     drone.state != Disabled && {
-      drone.battery = Js.Math.max_float(0.0, drone.battery -. drone.batteryDrainRate *. dt)
+      drone.battery = Math.max(0.0, drone.battery -. drone.batteryDrainRate *. dt)
       drone.battery <= 0.0
     }
   ) {
@@ -300,7 +300,7 @@ let updateState = (
               drone.hoverTimer = 0.0
             }
           }
-        | _ => drone.suspicion = Js.Math.max_float(0.0, drone.suspicion -. dt *. 0.1)
+        | _ => drone.suspicion = Math.max(0.0, drone.suspicion -. dt *. 0.1)
         }
         Some(detection)
       }
@@ -312,7 +312,7 @@ let updateState = (
         switch detection {
         | InDetectionZone(proximity) if proximity > 0.3 => {
             drone.lastKnownPlayerX = Some(playerX)
-            drone.suspicion = Js.Math.min_float(1.0, drone.suspicion +. dt *. 0.3)
+            drone.suspicion = Math.min(1.0, drone.suspicion +. dt *. 0.3)
             if drone.suspicion > 0.7 {
               drone.state = Tracking
             }
@@ -342,7 +342,7 @@ let updateState = (
               // Pursuit drones activate spotlight
               if drone.variant == Pursuit && alertLevel >= 2 {
                 drone.spotlightActive = true
-                drone.spotlightIntensity = Js.Math.min_float(1.0, drone.spotlightIntensity +. dt *. 0.5)
+                drone.spotlightIntensity = Math.min(1.0, drone.spotlightIntensity +. dt *. 0.5)
                 drone.state = Spotlighting
               }
 
@@ -386,7 +386,7 @@ let updateState = (
               drone.spotlightIntensity = 1.0
             }
           | NotDetected => {
-              drone.spotlightIntensity = Js.Math.max_float(0.0, drone.spotlightIntensity -. dt *. 0.3)
+              drone.spotlightIntensity = Math.max(0.0, drone.spotlightIntensity -. dt *. 0.3)
               if drone.spotlightIntensity <= 0.0 {
                 drone.spotlightActive = false
                 drone.state = Tracking
@@ -429,7 +429,7 @@ let updateState = (
       }
 
     | Charging => {
-        drone.battery = Js.Math.min_float(1.0, drone.battery +. drone.chargeRate *. dt)
+        drone.battery = Math.min(1.0, drone.battery +. drone.chargeRate *. dt)
         if drone.battery >= 0.95 {
           drone.state = Patrolling
         }

src/app/enemies/GuardNPC.res

@@ -447,7 +447,7 @@ let make = (
 let isInVisionCone = (guard: t, ~targetX: float, ~targetY: float): bool => {
   let dx = targetX -. guard.x
   let dy = targetY -. guard.y
-  let distance = Js.Math.sqrt(dx *. dx +. dy *. dy)
+  let distance = Math.sqrt(dx *. dx +. dy *. dy)
 
   let facingRight = guard.facing == Right
   let isBehind = (facingRight && dx < 0.0) || (!facingRight && dx > 0.0)
@@ -459,15 +459,15 @@ let isInVisionCone = (guard: t, ~targetX: float, ~targetY: float): bool => {
     let guardAngle = if facingRight {
       0.0
     } else {
-      Js.Math._PI
+      Math.Constants.pi
     }
     // SafeAngle.fromAtan2 guards against non-finite dy/dx inputs
     // (NaN/Infinity from degenerate positions would poison the entire
     // vision cone calculation and cause guards to never/always detect).
     let targetAngle = SafeAngle.fromAtan2(~y=dy, ~x=dx)
     let angleDiff = absFloat(targetAngle -. guardAngle)
-    let normalised = if angleDiff > Js.Math._PI {
-      2.0 *. Js.Math._PI -. angleDiff
+    let normalised = if angleDiff > Math.Constants.pi {
+      2.0 *. Math.Constants.pi -. angleDiff
     } else {
       angleDiff
     }
@@ -491,7 +491,7 @@ let detectPlayer = (
   } else {
     let dx = playerX -. guard.x
     let dy = playerY -. guard.y
-    let distance = Js.Math.sqrt(dx *. dx +. dy *. dy)
+    let distance = Math.sqrt(dx *. dx +. dy *. dy)
 
     let effectiveRange = if playerCrouching {
       guard.vision.range *. 0.6
@@ -700,9 +700,9 @@ let updateAntiHacker = (guard: t, ~dt: float, ~playerX: float, ~alertLevel: int)
       } else {
         0.0
       }
-      psych.courage = Js.Math.max_float(
+      psych.courage = Math.max(
         0.0,
-        Js.Math.min_float(1.0, baseCourage +. backupBonus +. alertPenalty +. proximityPenalty),
+        Math.min(1.0, baseCourage +. backupBonus +. alertPenalty +. proximityPenalty),
       )
 
       switch guard.state {
@@ -899,9 +899,9 @@ let updateRival = (guard: t, ~dt: float, ~playerX: float): unit => {
       // Track player awareness
       let playerDist = distanceTo(guard, ~x=playerX)
       if playerDist < 200.0 {
-        rival.awareness = Js.Math.min_float(1.0, rival.awareness +. dt *. 0.3)
+        rival.awareness = Math.min(1.0, rival.awareness +. dt *. 0.3)
       } else {
-        rival.awareness = Js.Math.max_float(0.0, rival.awareness -. dt *. 0.1)
+        rival.awareness = Math.max(0.0, rival.awareness -. dt *. 0.1)
       }
 
       switch guard.state {
@@ -1089,7 +1089,7 @@ let updateAssassin = (guard: t, ~dt: float, ~playerX: float): unit => {
             }
           | None => {
               // No waypoints  just fade and reposition randomly
-              ai.visibility = Js.Math.max_float(0.0, ai.visibility -. dt *. 0.3)
+              ai.visibility = Math.max(0.0, ai.visibility -. dt *. 0.3)
               if ai.visibility <= 0.05 {
                 guard.state = Hiding
               }
@@ -1330,7 +1330,7 @@ let renderGuard = (guard: t): unit => {
       let baseAngle = if guard.facing == Right {
         0.0
       } else {
-        Js.Math._PI
+        Math.Constants.pi
       }
       let startAngle = baseAngle -. guard.vision.halfAngle
       let endAngle = baseAngle +. guard.vision.halfAngle
@@ -1339,12 +1339,12 @@ let renderGuard = (guard: t): unit => {
         guard.coneGraphic
         ->Graphics.moveTo(0.0, -.h /. 2.0 -. 14.0)
         ->Graphics.lineTo(
-          Js.Math.cos(startAngle) *. guard.vision.range,
-          -.h /. 2.0 -. 14.0 +. Js.Math.sin(startAngle) *. guard.vision.range,
+          Math.cos(startAngle) *. guard.vision.range,
+          -.h /. 2.0 -. 14.0 +. Math.sin(startAngle) *. guard.vision.range,
         )
         ->Graphics.lineTo(
-          Js.Math.cos(endAngle) *. guard.vision.range,
-          -.h /. 2.0 -. 14.0 +. Js.Math.sin(endAngle) *. guard.vision.range,
+          Math.cos(endAngle) *. guard.vision.range,
+          -.h /. 2.0 -. 14.0 +. Math.sin(endAngle) *. guard.vision.range,
         )
         ->Graphics.lineTo(0.0, -.h /. 2.0 -. 14.0)
         ->Graphics.fill({"color": coneColor, "alpha": coneAlpha})
@@ -1520,7 +1520,7 @@ let update = (
         }
       }
     | Peripheral(amount) => {
-        guard.suspicion = Js.Math.min_float(1.0, guard.suspicion +. amount *. dt *. 0.5)
+        guard.suspicion = Math.min(1.0, guard.suspicion +. amount *. dt *. 0.5)
         let threshold = switch guard.rank {
         | BasicGuard => 0.85 // Very slow to notice
         | SecurityGuard => 0.65
@@ -1540,7 +1540,7 @@ let update = (
         | EliteGuard => 0.1 // Slow to forget
         | _ => 0.2
         }
-        guard.suspicion = Js.Math.max_float(0.0, guard.suspicion -. dt *. decayRate)
+        guard.suspicion = Math.max(0.0, guard.suspicion -. dt *. decayRate)
       }
     }
 

src/app/enemies/SecurityDog.res

@@ -189,7 +189,7 @@ let detectPlayer = (
   } else {
     let dx = playerX -. dog.x
     let dy = playerY -. dog.y
-    let distance = Js.Math.sqrt(dx *. dx +. dy *. dy)
+    let distance = Math.sqrt(dx *. dx +. dy *. dy)
 
     switch dog.variant {
     | GuardDog => // Scent detection  omnidirectional, ignores crouching/walls
@@ -207,15 +207,15 @@ let detectPlayer = (
         let baseAngle = if facingRight {
           0.0
         } else {
-          Js.Math._PI
+          Math.Constants.pi
         }
         // SafeAngle.fromAtan2 guards against non-finite dy/dx inputs
         // (NaN/Infinity from degenerate positions would poison the entire
         // detection cone calculation).
         let targetAngle = SafeAngle.fromAtan2(~y=dy, ~x=dx)
         let angleDiff = absFloat(targetAngle -. baseAngle)
-        let normalised = if angleDiff > Js.Math._PI {
-          2.0 *. Js.Math._PI -. angleDiff
+        let normalised = if angleDiff > Math.Constants.pi {
+          2.0 *. Math.Constants.pi -. angleDiff
         } else {
           angleDiff
         }
@@ -320,7 +320,7 @@ let updateState = (
     None
   } else if (
     dog.variant == RoboDog && {
-        dog.batteryLevel = Js.Math.max_float(0.0, dog.batteryLevel -. dt *. 0.002)
+        dog.batteryLevel = Math.max(0.0, dog.batteryLevel -. dt *. 0.002)
         dog.batteryLevel <= 0.0
       }
   ) {
@@ -352,7 +352,7 @@ let updateState = (
             Some(detection)
           }
         | _ => {
-            dog.suspicion = Js.Math.max_float(0.0, dog.suspicion -. dt *. 0.15)
+            dog.suspicion = Math.max(0.0, dog.suspicion -. dt *. 0.15)
             Some(NotDetected)
           }
         }
@@ -742,7 +742,7 @@ let renderDog = (dog: t): unit => {
           let baseAngle = if dog.facing == Right {
             0.0
           } else {
-            Js.Math._PI
+            Math.Constants.pi
           }
           let startAngle = baseAngle -. dog.detection.cameraHalfAngle
           let endAngle = baseAngle +. dog.detection.cameraHalfAngle
@@ -754,12 +754,12 @@ let renderDog = (dog: t): unit => {
             dog.detectionGraphic
             ->Graphics.moveTo(0.0, -.bodyH /. 2.0)
             ->Graphics.lineTo(
-              Js.Math.cos(startAngle) *. dog.detection.cameraRange,
-              -.bodyH /. 2.0 +. Js.Math.sin(startAngle) *. dog.detection.cameraRange,
+              Math.cos(startAngle) *. dog.detection.cameraRange,
+              -.bodyH /. 2.0 +. Math.sin(startAngle) *. dog.detection.cameraRange,
             )
             ->Graphics.lineTo(
-              Js.Math.cos(endAngle) *. dog.detection.cameraRange,
-              -.bodyH /. 2.0 +. Js.Math.sin(endAngle) *. dog.detection.cameraRange,
+              Math.cos(endAngle) *. dog.detection.cameraRange,
+              -.bodyH /. 2.0 +. Math.sin(endAngle) *. dog.detection.cameraRange,
             )
             ->Graphics.lineTo(0.0, -.bodyH /. 2.0)
             ->Graphics.fill({"color": coneColor, "alpha": 0.08})

src/app/pickups/WorldPickup.res

@@ -281,7 +281,7 @@ let makeCollectible = (~item: Inventory.item, ~x: float, ~groundY: float): t =>
 // Pulse alpha 0.61.0 based on game time
 let updateAnimation = (pickup: t, ~gameTime: float): unit => {
   if !pickup.collected {
-    let pulse = 0.8 +. 0.2 *. Js.Math.sin(gameTime *. 2.0 +. pickup.glowPhase)
+    let pulse = 0.8 +. 0.2 *. Math.sin(gameTime *. 2.0 +. pickup.glowPhase)
     Container.setAlpha(pickup.container, pulse)
   }
 }
@@ -295,7 +295,7 @@ let isInRange = (pickup: t, ~playerX: float, ~playerY: float): bool => {
   } else {
     let dx = playerX -. pickup.x
     let dy = playerY -. pickup.y
-    let dist = Js.Math.sqrt(dx *. dx +. dy *. dy)
+    let dist = Math.sqrt(dx *. dx +. dy *. dy)
     dist <= pickup.pickupRadius
   }
 }