Merge branch '5.0' into cacheable-query-params

Author: adriendupuis

.github/workflows/api_refs.yaml

@@ -73,6 +73,11 @@ jobs:
                   git diff-index --quiet --cached HEAD || git commit -m "PHP API Ref HTML"
                   git add docs/api/rest_api/rest_api_reference/rest_api_reference.html
                   git diff-index --quiet --cached HEAD || git commit -m "REST API Ref HTML"
+                  if [[ '4.6' != $BASE_BRANCH ]]; then
+                    git add docs/api/rest_api/rest_api_reference/openapi.yaml
+                    git add docs/api/rest_api/rest_api_reference/openapi.json
+                    git diff-index --quiet --cached HEAD || git commit -m "REST API OpenAPI spec"
+                  fi
 
             - name: Create Pull Request
               uses: peter-evans/create-pull-request@v7

.github/workflows/code_samples.yaml

@@ -46,6 +46,9 @@ jobs:
             - name: Run PHPStan analysis
               run: composer phpstan
 
+            - name: Deptrac
+              run: composer deptrac
+
             - name: Run rector
               run: vendor/bin/rector process --dry-run --ansi
 

.github/workflows/preview_comment.yaml

@@ -22,8 +22,9 @@ jobs:
 
         steps:
             - uses: actions/checkout@v4
-              with:
-                  fetch-depth: 0
+
+            -   name: Fetch base branch for comparison
+                run: git fetch origin ${{ github.base_ref }} --depth=1
 
             -   name: Create comment for changed files
                 run: |

.gitignore

@@ -11,3 +11,4 @@ auth.json
 .yarn
 yarn.lock
 docs/css/*.map
+.deptrac.cache

README.md

@@ -53,12 +53,33 @@ of the command.
 
 ## Testing the code samples
 
+### PHPStan
+
 This repository uses PHPStan to test the code samples. To run the tests locally execute the commands below:
 ```bash
 composer update
 composer phpstan
 ```
 
+Regenerate the baseline by running:
+```bash
+composer phpstan -- --generate-baseline
+```
+
+### Deptrac
+
+This repository uses Deptrac to test the code samples. To run the tests locally execute the commands below:
+
+```bash
+composer update
+composer deptrac
+```
+
+Regenerate the baseline by running:
+```bash
+vendor/bin/deptrac --formatter=baseline
+```
+
 ## Where to View
 
 https://doc.ibexa.co

code_samples/api/commerce/src/Command/CartCommand.php

@@ -12,11 +12,11 @@
 use Ibexa\Contracts\Cart\Value\EntryAddStruct;
 use Ibexa\Contracts\Cart\Value\EntryUpdateStruct;
 use Ibexa\Contracts\Checkout\Reorder\ReorderService;
+use Ibexa\Contracts\Core\Repository\PermissionResolver;
 use Ibexa\Contracts\Core\Repository\UserService;
 use Ibexa\Contracts\OrderManagement\OrderServiceInterface;
 use Ibexa\Contracts\ProductCatalog\CurrencyServiceInterface;
 use Ibexa\Contracts\ProductCatalog\ProductServiceInterface;
-use Ibexa\Core\Repository\Permission\PermissionResolver;
 use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
@@ -54,7 +54,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $cartsList = $this->cartService->findCarts($cartQuery);
 
         $cartsList->getCarts(); // array of CartInterface objects
-        $cartsList->getTotalCount(); // number of returned carts
+        $cartsList->getTotalCount(); // number of matching carts regardless of the limit
 
         foreach ($cartsList as $cart) {
             $output->writeln($cart->getIdentifier() . ': ' . $cart->getName());

code_samples/api/migration/src/Command/MigrationCommand.php

@@ -2,7 +2,7 @@
 
 namespace App\Command;
 
-use Ibexa\Migration\MigrationService;
+use Ibexa\Contracts\Migration\MigrationService;
 use Ibexa\Migration\Repository\Migration;
 use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;

code_samples/api/public_php_api/src/Command/SegmentCommand.php

@@ -4,7 +4,7 @@
 
 use Ibexa\Contracts\Core\Repository\PermissionResolver;
 use Ibexa\Contracts\Core\Repository\UserService;
-use Ibexa\Segmentation\Service\SegmentationService;
+use Ibexa\Contracts\Segmentation\SegmentationServiceInterface;
 use Ibexa\Segmentation\Value\SegmentCreateStruct;
 use Ibexa\Segmentation\Value\SegmentGroupCreateStruct;
 use Symfony\Component\Console\Attribute\AsCommand;
@@ -18,7 +18,7 @@
 class SegmentCommand extends Command
 {
     public function __construct(
-        private readonly SegmentationService $segmentationService,
+        private readonly SegmentationServiceInterface $segmentationService,
         private readonly UserService $userService,
         private readonly PermissionResolver $permissionResolver
     ) {

code_samples/back_office/images/src/PlaceholderProvider.php

@@ -52,6 +52,7 @@ private function getCustomLimitationValue(): bool
         return $customLimitationValues['value'] ?? false;
     }
 
+    #[\Override]
     public function performAccessCheck(): void
     {
         $this->traitPerformAccessCheck();