From c54fe2155aee0fb55d3171f287f02435f4c618dd Mon Sep 17 00:00:00 2001 From: Mofasa Date: Sat, 1 Dec 2018 14:49:29 +0800 Subject: [PATCH 1/2] Pdo, fixed sql error if emtpy filter --- ice/db/driver/pdo.zep | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ice/db/driver/pdo.zep b/ice/db/driver/pdo.zep index f740f1f2..8830141f 100644 --- a/ice/db/driver/pdo.zep +++ b/ice/db/driver/pdo.zep @@ -313,9 +313,13 @@ class Pdo implements DbInterface } let filtered = this->where(filters), - sql .= columns . " FROM " . sprintf(this->identifier, from) . " WHERE " . filtered[0], + sql .= columns . " FROM " . sprintf(this->identifier, from), values = filtered[1]; + if !empty filtered[0] { + sql .= " WHERE " . filtered[0]; + } + if isset options["group"] { if typeof options["group"] == "array" { let sql .= " GROUP BY " . implode(", ", options["group"]); From cc2942a96e9c9f6c9dd98f89db88f7db4b2e7386 Mon Sep 17 00:00:00 2001 From: Mofasa Date: Sat, 1 Dec 2018 14:57:54 +0800 Subject: [PATCH 2/2] let --- ice/db/driver/pdo.zep | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ice/db/driver/pdo.zep b/ice/db/driver/pdo.zep index 8830141f..ef80d92e 100644 --- a/ice/db/driver/pdo.zep +++ b/ice/db/driver/pdo.zep @@ -317,7 +317,7 @@ class Pdo implements DbInterface values = filtered[1]; if !empty filtered[0] { - sql .= " WHERE " . filtered[0]; + let sql .= " WHERE " . filtered[0]; } if isset options["group"] {