run through some test

Author: Jon Phenow

lib/saml_idp/request.rb

@@ -105,7 +105,7 @@ def valid?
         return false
       end
 
-      if !acceptable_acs_hosts.include?(acs_host)
+      if !acceptable_reponse_hosts.include?(response_host)
         log "No acceptable AssertionConsumerServiceURL, either configure them via config.assertion_consumer_service_hosts or match to your metadata_url host"
         return false
       end
@@ -141,19 +141,19 @@ def session_index
       @_session_index ||= xpath("//samlp:SessionIndex", samlp: samlp).first.try(:content)
     end
 
-    def acceptable_acs_hosts
-      (config.assertion_consumer_service_hosts || []) +
-        service_provider.metdata_url_host ? [service_provider.metdata_url_host] : []
+    def acceptable_reponse_hosts
+      Array(config.assertion_consumer_service_hosts) +
+        (service_provider.metadata_url_host ? [service_provider.metadata_url_host] : [])
     end
-    private :acceptable_acs_hosts
+    private :acceptable_reponse_hosts
 
-    def acs_host
-      uri = URI(acs_url)
+    def response_host
+      uri = URI(response_url)
       if uri
         uri.host
       end
     end
-    private :acs_host
+    private :response_host
 
     def document
       @_document ||= Saml::XML::Document.parse(raw_xml)

spec/acceptance/idp_controller_spec.rb

@@ -4,8 +4,9 @@
   scenario 'Login via default signup page' do
     saml_request = make_saml_request("http://foo.example.com/saml/consume")
     visit "/saml/auth?SAMLRequest=#{CGI.escape(saml_request)}"
-    fill_in 'Email', :with => "foo@example.com"
-    fill_in 'Password', :with => "okidoki"
+    expect(status_code).to eq(200)
+    fill_in 'email', :with => "foo@example.com"
+    fill_in 'password', :with => "okidoki"
     click_button 'Sign in'
     click_button 'Submit'   # simulating onload
     expect(current_url).to eq('http://foo.example.com/saml/consume')

spec/spec_helper.rb

@@ -29,6 +29,7 @@
 
   config.before do
     SamlIdp.configure do |c|
+      c.assertion_consumer_service_hosts = ["foo.example.com"]
       c.attributes = {
         emailAddress: {
           name: "email-address",
@@ -45,5 +46,6 @@
   end
 end
 
+SamlIdp::Default::SERVICE_PROVIDER[:metadata_url] = 'https://example.com/meta'
 SamlIdp::Default::SERVICE_PROVIDER[:assertion_consumer_logout_service_url] = 'https://foo.example.com/saml/logout'
 Capybara.default_host = "https://app.example.com"