Skip to content

Commit ab99840

Browse files
author
Piechota, Michael
committed
Pass CDK diff output via env to avoid JS template injection
1 parent a5b9eac commit ab99840

1 file changed

Lines changed: 10 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,13 +168,20 @@ jobs:
168168
169169
- name: Post CDK diff comment
170170
uses: actions/github-script@v7
171+
# Pass data via env so script content is static — avoids JS parser
172+
# errors when diff output contains `${...}` (CloudFormation tokens).
173+
env:
174+
DIFF_OUTPUT: ${{ steps.diff.outputs.diff_output }}
175+
HAS_CHANGES: ${{ steps.diff.outputs.has_changes }}
176+
DIFF_ENV: ${{ inputs.diff-environment }}
171177
with:
172178
script: |
173-
const diff = `${{ steps.diff.outputs.diff_output }}`;
174-
const hasChanges = `${{ steps.diff.outputs.has_changes }}` === 'true';
179+
const diff = process.env.DIFF_OUTPUT || '';
180+
const hasChanges = process.env.HAS_CHANGES === 'true';
181+
const env = process.env.DIFF_ENV;
175182
const icon = hasChanges ? '⚠️' : '✅';
176183
const body = [
177-
`## ${icon} CDK Diff — \`${{ inputs.diff-environment }}\``,
184+
`## ${icon} CDK Diff — \`${env}\``,
178185
'',
179186
'```',
180187
diff.slice(0, 60000), // GitHub comment limit guard

0 commit comments

Comments
 (0)