fix(start): add ability to install via branch name. fixes #2052.

Author: jthoms1

packages/ionic/src/commands/start.ts

@@ -123,6 +123,8 @@ export class StartCommand extends Command {
     let [projectName, starterTemplateName] = inputs;
     let appName = <string>options['appname'] || projectName;
     let cloudAppId = <string>options['cloud-app-id'] || '';
+    let starterBranchName = <string>options['starterBranchName'] || 'master';
+    let wrapperBranchName = <string>options['wrapperBranchName'] || 'master';
     let installer = 'npm';
     let projectRoot: string;
 
@@ -189,10 +191,12 @@ export class StartCommand extends Command {
 
     let baseArchiveResponse;
     let archiveResponse;
+    let wrapperBranchPath = starterType.baseArchive.replace('<BRANCH_NAME>', wrapperBranchName);
+    let starterBranchPath = starterTemplate.archive.replace('<BRANCH_NAME>', starterBranchName);
     try {
       [ baseArchiveResponse, archiveResponse] = await Promise.all([
-        fetch(starterType.baseArchive),
-        fetch(starterTemplate.archive)
+        fetch(wrapperBranchPath),
+        fetch(starterBranchPath)
       ]);
     } catch (e) {
       if (['ETIMEOUT', 'ENOTFOUND'].includes(e.code)) {

packages/ionic/src/lib/starter-templates.ts

@@ -8,7 +8,7 @@ export const STARTER_TYPES: StarterTemplateType[] = [
   {
     id: 'ionic-angular',
     name: 'v2',
-    baseArchive: 'https://github.com/driftyco/ionic2-app-base/archive/master.tar.gz',
+    baseArchive: 'https://github.com/driftyco/ionic2-app-base/archive/<BRANCH_NAME>.tar.gz',
     buildDependencies: [
       '@ionic/cli-plugin-cordova',
       '@ionic/cli-plugin-ionic-angular'
@@ -17,7 +17,7 @@ export const STARTER_TYPES: StarterTemplateType[] = [
   {
     id: 'ionic1',
     name: 'v1',
-    baseArchive: 'https://github.com/driftyco/ionic-app-base/archive/master.tar.gz',
+    baseArchive: 'https://github.com/driftyco/ionic-app-base/archive/<BRANCH_NAME>.tar.gz',
     buildDependencies: [
       '@ionic/cli-plugin-cordova',
       '@ionic/cli-plugin-ionic1'
@@ -31,76 +31,76 @@ export const STARTER_TEMPLATES: StarterTemplate[] = [
     typeId: 'ionic-angular',
     description: 'A starting project with a simple tabbed interface',
     path: 'driftyco/ionic2-starter-tabs',
-    archive: 'https://github.com/driftyco/ionic2-starter-tabs/archive/master.tar.gz'
+    archive: 'https://github.com/driftyco/ionic2-starter-tabs/archive/<BRANCH_NAME>.tar.gz'
   },
   {
     name: 'blank',
     typeId: 'ionic-angular',
     description: 'A blank starter project',
     path: 'driftyco/ionic2-starter-blank',
-    archive: 'https://github.com/driftyco/ionic2-starter-blank/archive/master.tar.gz'
+    archive: 'https://github.com/driftyco/ionic2-starter-blank/archive/<BRANCH_NAME>.tar.gz'
   },
   {
     name: 'sidemenu',
     typeId: 'ionic-angular',
     description: 'A starting project with a side menu with navigation in the content area',
     path: 'driftyco/ionic2-starter-sidemenu',
-    archive: 'https://github.com/driftyco/ionic2-starter-sidemenu/archive/master.tar.gz'
+    archive: 'https://github.com/driftyco/ionic2-starter-sidemenu/archive/<BRANCH_NAME>.tar.gz'
   },
   {
     name: 'conference',
     typeId: 'ionic-angular',
     description: 'A project that demonstrates a realworld application',
     path: 'driftyco/ionic-conference-app',
-    archive: 'https://github.com/driftyco/ionic-conference-app/archive/master.tar.gz'
+    archive: 'https://github.com/driftyco/ionic-conference-app/archive/<BRANCH_NAME>.tar.gz'
   },
   {
     name: 'tutorial',
     typeId: 'ionic-angular',
     description: 'A tutorial based project that goes along with the Ionic documentation',
     path: 'driftyco/ionic2-starter-tutorial',
-    archive: 'https://github.com/driftyco/ionic2-starter-tutorial/archive/master.tar.gz'
+    archive: 'https://github.com/driftyco/ionic2-starter-tutorial/archive/<BRANCH_NAME>.tar.gz'
   },
   {
     name: 'maps',
     typeId: 'ionic1',
     description: 'An Ionic starter project using Google Maps and a side menu',
     path: 'driftyco/ionic-starter-maps',
-    archive: 'https://github.com/driftyco/ionic-starter-maps/archive/master.tar.gz'
+    archive: 'https://github.com/driftyco/ionic-starter-maps/archive/<BRANCH_NAME>.tar.gz'
   },
   {
     name: 'tabs',
     typeId: 'ionic1',
     description: 'A starting project for Ionic using a simple tabbed interface',
     path: 'driftyco/ionic-starter-maps',
-    archive: 'https://github.com/driftyco/ionic-starter-tabs/archive/master.tar.gz'
+    archive: 'https://github.com/driftyco/ionic-starter-tabs/archive/<BRANCH_NAME>.tar.gz'
   },
   {
     name: 'sidemenu',
     typeId: 'ionic1',
     description: 'A starting project for Ionic using a side menu with navigation in the content area',
     path: 'driftyco/ionic-starter-maps',
-    archive: 'https://github.com/driftyco/ionic-starter-sidemenu/archive/master.tar.gz'
+    archive: 'https://github.com/driftyco/ionic-starter-sidemenu/archive/<BRANCH_NAME>.tar.gz'
   },
   {
     name: 'blank',
     typeId: 'ionic1',
     description: 'A blank starter project for Ionic',
     path: 'driftyco/ionic-starter-maps',
-    archive: 'https://github.com/driftyco/ionic-starter-blank/archive/master.tar.gz'
+    archive: 'https://github.com/driftyco/ionic-starter-blank/archive/<BRANCH_NAME>.tar.gz'
   },
   {
     name: 'salesforce',
     typeId: 'ionic1',
     description: 'A starter project for Ionic and Salesforce',
     path: 'driftyco/ionic-starter-maps',
-    archive: 'https://github.com/driftyco/ionic-starter-salesforce/archive/master.tar.gz'
+    archive: 'https://github.com/driftyco/ionic-starter-salesforce/archive/<BRANCH_NAME>.tar.gz'
   },
   {
     name: 'complex-list',
     typeId: 'ionic1',
     description: 'A complex list starter template',
     path: 'driftyco/ionic-starter-maps',
-    archive: 'https://github.com/driftyco/ionic-starter-complex-list/archive/master.tar.gz'
+    archive: 'https://github.com/driftyco/ionic-starter-complex-list/archive/<BRANCH_NAME>.tar.gz'
   }
 ];