Skip to content

fix(): ionic doctor ViewportFixNotSet Ailment#3809

Merged
imhoffd merged 1 commit into
ionic-team:developfrom
reajuria:patch-1
Jan 4, 2019
Merged

fix(): ionic doctor ViewportFixNotSet Ailment#3809
imhoffd merged 1 commit into
ionic-team:developfrom
reajuria:patch-1

Conversation

@reajuria

@reajuria reajuria commented Jan 4, 2019

Copy link
Copy Markdown
Contributor

Regex doesn't match on a multiline meta tag, an strict matcher is proposed to prevent match on other meta tags, only should match if a meta tag has name="viewport" property

done in test bench: https://regex101.com/r/yy1zT2/1

Regex doesn't match on a multiline meta tag, an strict matcher is proposed to prevent match on other meta tags, only should match if a meta tag has name="viewport" property

done in test bench: https://regex101.com/r/yy1zT2/1
@imhoffd

imhoffd commented Jan 4, 2019

Copy link
Copy Markdown
Contributor

@reajuria I don't think that's working. It's not finding the other valid viewport settings in your test bench.

I'm more comfortable with just accepting characters that aren't a closing bracket (>), such as this regex:

\<meta[^>]*?name="viewport"[^>]*?viewport-fit=cover

@imhoffd

imhoffd commented Jan 4, 2019

Copy link
Copy Markdown
Contributor

Ah, nevermind, I was doing that wrong. Sorry, never used that website.

@imhoffd imhoffd merged commit 6aa7ae6 into ionic-team:develop Jan 4, 2019
@imhoffd

imhoffd commented Jan 4, 2019

Copy link
Copy Markdown
Contributor

Thanks @reajuria!! Great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants