Skip to content

fix(Appflow): Fix issue with deploy add and deploy configure commands where sometimes neccessary variables weren't correctly set.#4634

Merged
giocalitri merged 3 commits into
developfrom
fix-deploy-configure-add-bug
Jan 27, 2021
Merged

fix(Appflow): Fix issue with deploy add and deploy configure commands where sometimes neccessary variables weren't correctly set.#4634
giocalitri merged 3 commits into
developfrom
fix-deploy-configure-add-bug

Conversation

@nphyatt

@nphyatt nphyatt commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

fixes #4633

… where sometimes neccessary variables weren't correctly set.
@nphyatt nphyatt requested review from giocalitri and imhoffd January 27, 2021 19:07
Comment thread packages/@ionic/cli/src/commands/deploy/core.ts Outdated
Comment thread packages/@ionic/cli/src/commands/deploy/core.ts Outdated
Comment thread packages/@ionic/cli/src/commands/deploy/core.ts Outdated
Comment thread packages/@ionic/cli/src/commands/deploy/add.ts Outdated
@giocalitri giocalitri force-pushed the fix-deploy-configure-add-bug branch from 2a0eb19 to 883c080 Compare January 27, 2021 20:20
@giocalitri giocalitri force-pushed the fix-deploy-configure-add-bug branch from 883c080 to c10c3fe Compare January 27, 2021 20:45
@giocalitri giocalitri merged commit be6cf2e into develop Jan 27, 2021
@giocalitri giocalitri deleted the fix-deploy-configure-add-bug branch January 27, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ionic deploy add command doesn't perform required configuration

3 participants