Skip to content

chore: Cap is no longer experimental and is default for Angular#4745

Merged
nphyatt merged 1 commit into
developfrom
cap-default-for-all
Aug 11, 2021
Merged

chore: Cap is no longer experimental and is default for Angular#4745
nphyatt merged 1 commit into
developfrom
cap-default-for-all

Conversation

@nphyatt

@nphyatt nphyatt commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@jcesarmobile jcesarmobile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can now delete the block where it used to prompt

if (options['capacitor'] === null && !options['cordova']) {
const confirm = await this.env.prompt({
type: 'confirm',
name: 'confirm',
message: 'Integrate your new app with Capacitor to target native iOS and Android?',
default: false,
});
if (confirm) {
options['capacitor'] = true;
}
}

@nphyatt nphyatt merged commit d81e08b into develop Aug 11, 2021
@nphyatt nphyatt deleted the cap-default-for-all branch August 11, 2021 15:21
@ziftytodd

Copy link
Copy Markdown

This change now installs capacitor on all starter projects. Maybe it's just me, but I don't want capacitor on my web only projects. Please bring back the prompt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants