From 14d594f6bede28cf97682800f59d8530dc411900 Mon Sep 17 00:00:00 2001 From: "Rafael E. Ajuria" Date: Fri, 4 Jan 2019 16:22:44 -0600 Subject: [PATCH] fix(): ionic doctor ViewportFixNotSet Ailment Regex doesn't match on a multiline meta tag, an strict matcher is proposed to prevent match on other meta tags, only should match if a meta tag has name="viewport" property done in test bench: https://regex101.com/r/yy1zT2/1 --- packages/ionic/src/lib/doctor/ailments/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ionic/src/lib/doctor/ailments/index.ts b/packages/ionic/src/lib/doctor/ailments/index.ts index 92819be214..cbe649a2bd 100644 --- a/packages/ionic/src/lib/doctor/ailments/index.ts +++ b/packages/ionic/src/lib/doctor/ailments/index.ts @@ -275,7 +275,7 @@ export class ViewportFitNotSet extends Ailment { async detected() { const indexHtml = await readFile(path.resolve(await this.project.getSourceDir(), 'index.html'), { encoding: 'utf8' }); - const m = indexHtml.match(/\/); return !Boolean(m); }