From de4a8e56563d011acbae7297d5d91a36b9d1f300 Mon Sep 17 00:00:00 2001 From: jcesarmobile Date: Thu, 13 Jun 2019 18:23:22 +0200 Subject: [PATCH 1/2] fix(cordova): don't append --save to plugin commands --- packages/ionic/src/commands/cordova/plugin.ts | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/packages/ionic/src/commands/cordova/plugin.ts b/packages/ionic/src/commands/cordova/plugin.ts index d9ed3d3efa..418b290fc7 100644 --- a/packages/ionic/src/commands/cordova/plugin.ts +++ b/packages/ionic/src/commands/cordova/plugin.ts @@ -1,5 +1,4 @@ import { MetadataGroup, contains, validate, validators } from '@ionic/cli-framework'; -import * as lodash from 'lodash'; import { CommandInstanceInfo, CommandLineInputs, CommandLineOptions, CommandMetadata, CommandPreRun } from '../../definitions'; import { input } from '../../lib/color'; @@ -74,18 +73,9 @@ Like running ${input('cordova plugin')} directly, but provides friendly checks. } async run(inputs: CommandLineInputs, options: CommandLineOptions): Promise { - const [ action ] = inputs; const metadata = await this.getMetadata(); const cordovaArgs = filterArgumentsForCordova(metadata, options); - if ( - (action === 'add' || action === 'remove') && - (options['save'] !== false && !options['nosave']) && - lodash.intersection(options['--'] || [], ['--save', '--nosave', '--no-save']).length === 0 - ) { - cordovaArgs.push('--save'); - } - await this.runCordova(cordovaArgs, {}); } } From 8fb7a8e3d9f6e0d16fe265a0833ba2025cd8c911 Mon Sep 17 00:00:00 2001 From: Daniel Imhoff Date: Sat, 15 Jun 2019 15:12:24 -0500 Subject: [PATCH 2/2] don't append --save for platform commands --- packages/ionic/src/commands/cordova/platform.ts | 9 --------- 1 file changed, 9 deletions(-) diff --git a/packages/ionic/src/commands/cordova/platform.ts b/packages/ionic/src/commands/cordova/platform.ts index d53935219c..c748cc3047 100644 --- a/packages/ionic/src/commands/cordova/platform.ts +++ b/packages/ionic/src/commands/cordova/platform.ts @@ -1,5 +1,4 @@ import { contains, validate, validators } from '@ionic/cli-framework'; -import * as lodash from 'lodash'; import { CommandInstanceInfo, CommandLineInputs, CommandLineOptions, CommandMetadata, CommandPreRun } from '../../definitions'; import { input } from '../../lib/color'; @@ -91,14 +90,6 @@ Like running ${input('cordova platform')} directly, but adds default Ionic icons const metadata = await this.getMetadata(); const cordovaArgs = filterArgumentsForCordova(metadata, options); - if ( - (action === 'add' || action === 'remove') && - (options['save'] !== false && !options['nosave']) && - lodash.intersection(options['--'] || [], ['--save', '--nosave', '--no-save']).length === 0 - ) { - cordovaArgs.push('--save'); - } - await this.runCordova(cordovaArgs, {}); const isLoggedIn = this.env.session.isLoggedIn();