when sending blocks in bitswap, close streams asynchronously#5258
Merged
whyrusleeping merged 1 commit intomasterfrom Jul 18, 2018
Merged
when sending blocks in bitswap, close streams asynchronously#5258whyrusleeping merged 1 commit intomasterfrom
whyrusleeping merged 1 commit intomasterfrom
Conversation
Otherwise, we tie up the bitswap worker until the other side responds with an EOF. fixes #5247 related to libp2p/go-libp2p-net#28 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned
Stebalien
added
need/review
magik6k
approved these changes
Jul 18, 2018
Member
magik6k
left a comment
magik6k
left a comment
There was a problem hiding this comment.
Tried with js-ipfs, works way better!
Member
|
(very heavy example connecting to my server running this patch: https://ipfs.io/ipfs/QmZndUQvURHYJTgFJCfdhHDTKsDPMZffrJreGf2eAf9uPb/#/repo/QmU1HJJDFSM8JJq4r31wSLfj51oysQCswz7aL78UWZHuMC/compare/master...feat%2Fcoreapi-paths) |
Member
Author
|
Yeah, the memory issues don't look too bad. I'm working on a less crappy fix but it'll take a bit of time. |
Stebalien
added
RFM
and removed
status/in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, we tie up the bitswap worker until the other side responds with an EOF.
fixes #5247
related to libp2p/go-libp2p-net#28