Skip to content

test: testLargeWriteChunks: seek before reading#5276

Merged
whyrusleeping merged 1 commit intoipfs:masterfrom
schomatis:fix/dag-mod/testLargeWriteChunks/seek
Jul 23, 2018
Merged

test: testLargeWriteChunks: seek before reading#5276
whyrusleeping merged 1 commit intoipfs:masterfrom
schomatis:fix/dag-mod/testLargeWriteChunks/seek

Conversation

@schomatis
Copy link
Copy Markdown
Contributor

@schomatis schomatis commented Jul 23, 2018

This should be the last of the seek-before-reading errors in the tests.

Needed for #5257.

@schomatis
test: testLargeWriteChunks: seek before reading
c6fb304 
License: MIT
Signed-off-by: Lucas Molas <schomatis@gmail.com>
@schomatis schomatis added kind/bug A bug in existing code (including security flaws) topic/UnixFS Topic UnixFS labels Jul 23, 2018
@schomatis schomatis added this to the Files API Documentation milestone Jul 23, 2018
@schomatis schomatis self-assigned this Jul 23, 2018
@schomatis schomatis requested a review from Kubuxu as a code owner July 23, 2018 02:05
@ghost ghost added the status/in-progress In progress label Jul 23, 2018
@schomatis schomatis added need/review Needs a review and removed status/in-progress In progress labels Jul 23, 2018
@whyrusleeping whyrusleeping merged commit 80fcc4e into ipfs:master Jul 23, 2018
@schomatis schomatis deleted the fix/dag-mod/testLargeWriteChunks/seek branch July 23, 2018 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@schomatis schomatis

Labels

kind/bug A bug in existing code (including security flaws) need/review Needs a review topic/UnixFS Topic UnixFS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@schomatis @whyrusleeping