Update go-libp2p, fix tests with weak RSA keys#6555
Merged
Conversation
Stebalien
reviewed
Aug 5, 2019
Member
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
Looks like the tests in interface-go-ipfs-core need to be updated: https://github.com/ipfs/interface-go-ipfs-core/blob/master/tests/key.go (not sure how).
Stebalien
force-pushed
the
feat/update-libp2p
branch
from
a1cac77 to
0871fa3
Compare
Stebalien
force-pushed
the
feat/update-libp2p
branch
from
87f5e79 to
2d09c3a
Compare
We can no longer test this with bad keys. Unfortunately, good keys will likely contain a newline and we have no way to send such keys to the server due to how API requests are formatted.
"identity" is the official name
Stebalien
force-pushed
the
feat/update-libp2p
branch
from
04d4f2e to
ce96440
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All that remains is bumping
interface-go-ipfs-core.